Bug 33281 - We should reuse MediaControlTimeDisplayElement::formatTime function
Summary: We should reuse MediaControlTimeDisplayElement::formatTime function
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 17:18 PST by Chris Marrin
Modified: 2023-10-13 08:22 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-01-06 17:18:46 PST 
This function is currently duplicated in FullscreenVideoController on Windows. We should make the function a static method so it can be reused.
Comment 1 Ahmad Saleem 2023-10-13 08:22:22 PDT 
This patch merged 'MediaControlTimeDisplayElement' into 'MediaControlElementTypes.cpp'.

https://github.com/WebKit/WebKit/commit/f9e9a9581511ef57234ffbd25cd6a7532123b54e

and this commit also deleted above file:

https://github.com/WebKit/WebKit/commit/e3e80694948e94e81d10faf2c0da5fb213ece5e8

Plus no function with '::formatTime' exist as per quick search.

I don't think this 2010 old bug would add much value and if needed any refactoring, it can be done in new bug.

I am marking this as 'RESOLVED CONFIGURATION CHANGED' but will CC - Eric and Jer for any input.