WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
33281
We should reuse MediaControlTimeDisplayElement::formatTime function
https://bugs.webkit.org/show_bug.cgi?id=33281
Summary
We should reuse MediaControlTimeDisplayElement::formatTime function
Chris Marrin
Reported
2010-01-06 17:18:46 PST
This function is currently duplicated in FullscreenVideoController on Windows. We should make the function a static method so it can be reused.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-10-13 08:22:22 PDT
This patch merged 'MediaControlTimeDisplayElement' into 'MediaControlElementTypes.cpp'.
https://github.com/WebKit/WebKit/commit/f9e9a9581511ef57234ffbd25cd6a7532123b54e
and this commit also deleted above file:
https://github.com/WebKit/WebKit/commit/e3e80694948e94e81d10faf2c0da5fb213ece5e8
Plus no function with '::formatTime' exist as per quick search. I don't think this 2010 old bug would add much value and if needed any refactoring, it can be done in new bug. I am marking this as 'RESOLVED CONFIGURATION CHANGED' but will CC - Eric and Jer for any input.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug