Created attachment 45968 [details]
http://trac.webkit.org/changeset/52831 broke PNG-in-ICO decoding. Testcase attached. Will fix soon.
sorry it's my bug.
see line 121 in PNGImageDecoder.cpp:
if ((sizeOnly && decoder->isSizeAvailable()) || m_hasFinishedDecoding)
just chaning "break" to "return" should fix it.
Created attachment 45973 [details]
the candidate patch
Attachment 45973 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
File "WebKitTools/Scripts/check-webkit-style", line 98, in <module>
File "WebKitTools/Scripts/check-webkit-style", line 62, in main
defaults = style.ArgumentDefaults(style.DEFAULT_OUTPUT_FORMAT,
AttributeError: 'module' object has no attribute 'ArgumentDefaults'
Sorry for the spam. Stylebot is sick.
Looks like this caused crashes:
I think we'll need to roll this out. :(
http://trac.webkit.org/changeset/52862 was the original commit.
Do we not have a way to test image decoders? I'm surprised this landed w/o a test case?
Yong doesn't seem to be around on IRC, so I'm rolling this out in hopes it will fix the crashes on the bot.
Rolled out in http://trac.webkit.org/changeset/52871. Peter Kasting notes that we may need to roll out r52831 as well, otherwise this breaks chromium. This change should have been unrelated. If it's found to be unrelated, I'll roll it back in.
I'm rolling this back in after further discussions with Peter and Yong. I'm testing it on Leopard Debug first to make sure.
The leopard build is broken at the moment due to http://trac.webkit.org/changeset/52872, so I can't land the re-land yet.
Committed r52880: <http://trac.webkit.org/changeset/52880>