Inherits the following struct from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class IconDatabaseClient - loader/icon/IconDatabase.cpp:89
Created attachment 45960 [details] proposed patch
style-queue ran check-webkit-style on attachment 45960 [details] without any errors.
Comment on attachment 45960 [details] proposed patch This is an Abstract Base Class. I don't think that this interface should require non-copyable. The implementors of this interface should inherit from NonCopyable or FastAllocBase instead, no?
(In reply to comment #3) > This is an Abstract Base Class. It's not. It has no pure virtual functions and is instantiated, as the patch says, on line 89 of IconDatabase.cpp. However, I think it would make more sense if it was an abstract base class. The version that does nothing could be derived from it. I think there's no harm in making the change from this patch, but it's not great to have this client different from other clients.
So, what should be the best solution? Using fastNew in this case wouldn't be nice. Add an extra class? Or Inherit this client?
(In reply to comment #5) > So, what should be the best solution? Using fastNew in this case wouldn't be > nice. Add an extra class? Or Inherit this client? I know you’re hoping I’ll decide, but both options seem OK to me.
Comment on attachment 45960 [details] proposed patch Okay, this change modifies fewest. I marked r? the patch again.
Attachment 45960 [details] was posted by a committer and has review+, assigning to Zoltan Horvath for commit.
Comment on attachment 45960 [details] proposed patch Clearing flags on attachment: 45960 Committed r54210: <http://trac.webkit.org/changeset/54210>
All reviewed patches have been landed. Closing bug.