Bug 33250 - [Qt] windowsKeyCodeForKeyEvent() returns 0 for arrow keys on numeric-pad
Summary: [Qt] windowsKeyCodeForKeyEvent() returns 0 for arrow keys on numeric-pad
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2010-01-06 01:08 PST by Kinuko Yasuda
Modified: 2010-01-06 22:15 PST (History)
3 users (show)

See Also:

patch 1 (5.25 KB, patch)
2010-01-06 01:23 PST, Kinuko Yasuda
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-01-06 01:08:30 PST
Currently QT returns 0 as windowsVirtualKeyCode for any key events other than 0-9 and +-*/ keys on numeric-pad.
This indirectly makes a layout test fast/tests/keydown-numpad-keys.html failing.
Comment 1 Kinuko Yasuda 2010-01-06 01:23:11 PST
Created attachment 45957 [details]
patch 1
Comment 2 Eric Seidel (no email) 2010-01-06 09:01:52 PST
Comment on attachment 45957 [details]
patch 1

Looks OK.
Comment 3 WebKit Commit Bot 2010-01-06 18:27:43 PST
Comment on attachment 45957 [details]
patch 1

Rejecting patch 45957 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
ile WebCore/platform/qt/PlatformKeyboardEventQt.cpp
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp
Hunk #1 FAILED at 38.
Hunk #2 succeeded at 135 (offset 19 lines).
Hunk #3 succeeded at 150 (offset 19 lines).
1 out of 3 hunks FAILED -- saving rejects to file WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp.rej
patching file WebKitTools/DumpRenderTree/qt/EventSenderQt.h
Hunk #1 succeeded at 56 (offset 2 lines).

Full output: http://webkit-commit-queue.appspot.com/results/165156
Comment 4 Eric Seidel (no email) 2010-01-06 19:45:21 PST
Sorry.  The commit-queue was blocked all day by a very red tree.  Looks like someone else checked in in the meanwhile and made your patch not apply.  Normally it doesn't take more than 15 minutes between when we set cq+ and when your patch is landed.

You'll need to either get someone to land this manually, or post an updated patch so that we can r+/cq+ it.

Comment 5 Kent Tamura 2010-01-06 22:15:04 PST
Landed manually: http://trac.webkit.org/changeset/52902