WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 28092
33246
webkit-patch land should warn when changelog doesn't match committer
https://bugs.webkit.org/show_bug.cgi?id=33246
Summary
webkit-patch land should warn when changelog doesn't match committer
Ojan Vafai
Reported
2010-01-05 18:25:53 PST
I just had the following happen: 1. git svn rebase successfully merged my ChangeLog file, but didn't put my entry at the top 2. bugzilla-tool land-diff committed my change with the wrong commit message See
http://trac.webkit.org/changeset/52844
Technically, I should have noticed in the diff that the ChangeLog entry wasn't at the top, but it would be nice to be a bit more idiot-proof. Can land-diff confirm that you want to commit if the email address doesn't match git's configured email address? Obviously, this would always be true on the commit bot, but for human beings committing, I think this is by far the common case (i.e. that they're committing their own patches).
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-01-19 17:00:18 PST
We have like 8 dupes of this bug on file. Git users run into this kind of thing all the time. :(
Eric Seidel (no email)
Comment 2
2010-04-01 23:21:52 PDT
*** This bug has been marked as a duplicate of
bug 28092
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug