RESOLVED FIXED 33236
Remove m_identifierTable pointer from UString 
https://bugs.webkit.org/show_bug.cgi?id=33236
Summary Remove m_identifierTable pointer from UString
Gavin Barraclough
Reported 2010-01-05 16:29:39 PST
Currently every string holds a pointer so that during destruction, if a string has been used as an identifier, it can remove itself from the table. By instead accessing the identifierTable via a thread specific tracking the table associated with the current globaldata, we can save the memory cost of this pointer.
Attachments
The patch (28.59 KB, patch)
2010-01-05 16:51 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-01-05 16:51:35 PST
Created attachment 45940 [details] The patch
WebKit Review Bot
Comment 2 2010-01-05 17:17:52 PST
Attachment 45940 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/Identifier.cpp:270: g_identifierTableSpecific is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/runtime/Identifier.h:156: g_identifierTableSpecific is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/API/APIShims.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3
Sam Weinig
Comment 3 2010-01-05 19:37:09 PST
Comment on attachment 45940 [details] The patch > + (JSC::APICallbackShim::~APICallbackShim): > + > + - change the API shims to trck the identifierTable of the current JSGlobalData. MORE AS.
Gavin Barraclough
Comment 4 2010-01-06 11:34:39 PST
Transmitting file data .................... Committed revision 52856.
Note You need to log in before you can comment on or make changes to this bug.