Bug 33232 - [v8] Move V8DOMWindowShell to ScriptController
Summary: [v8] Move V8DOMWindowShell to ScriptController
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-05 15:04 PST by Adam Barth
Modified: 2014-12-16 00:48 PST (History)
4 users (show)

See Also:

Patch (20.66 KB, patch)
2010-01-05 15:07 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-05 15:04:33 PST
[v8] Move V8DOMWindowShell to ScriptController
Comment 1 Adam Barth 2010-01-05 15:07:11 PST
Created attachment 45934 [details]
Comment 2 Adam Barth 2010-01-05 15:07:31 PST
I tried to keep this one small...  Not sure I succeeded.
Comment 3 WebKit Review Bot 2010-01-05 15:10:18 PST
style-queue ran check-webkit-style on attachment 45934 [details] without any errors.
Comment 4 Dimitri Glazkov (Google) 2010-01-05 16:35:48 PST
Comment on attachment 45934 [details]


> +    ~V8DOMWindowShell();


> +        // FIXME: I be we can clean this up a bit!

We be cleanin' :D
Comment 5 Adam Barth 2010-01-05 17:39:06 PST
Comment on attachment 45934 [details]

Waiting for the kr build to unbust before landing.
Comment 6 Adam Barth 2010-01-05 19:09:34 PST
Committed r52847: <http://trac.webkit.org/changeset/52847>
Comment 7 Adam Barth 2010-01-07 12:01:15 PST
Reverted r52847 for reason:

Might have caused a perf regression.

Committed r52937: <http://trac.webkit.org/changeset/52937>
Comment 8 Adam Barth 2010-01-07 12:08:27 PST
Committed r52938: <http://trac.webkit.org/changeset/52938>
Comment 9 Peter Kasting 2010-01-07 18:42:45 PST
Reopening, since the patch was backed out.
Comment 10 Peter Kasting 2010-01-07 18:43:11 PST
Comment on attachment 45934 [details]

Clearing flags on patch that was backed out.
Comment 11 Brian Burg 2014-12-16 00:48:26 PST
Closing some V8-related work items.