Bug 33229 - Don't use renderer for Resources in SVGRenderBase::prepareToRenderSVGContent
Summary: Don't use renderer for Resources in SVGRenderBase::prepareToRenderSVGContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 68469 26389
  Show dependency tree / graph
 
Reported: 2010-01-05 14:09 PST by Dirk Schulze
Modified: 2014-05-12 05:54 PDT (History)
2 users (show)

See Also:

Attachments
Don't use Renderer for SVGResource calculations (47.49 KB, patch)
2010-01-05 14:24 PST, Dirk Schulze 		zimmermann: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-01-05 14:09:03 PST 
Don't use renderer for Resources in SVGRenderBase::prepareToRenderSVGContent. Some Renderer don't provide correct boundingBoxes or don't inherit from SVGRenderBase. This can cause an ASSERT in RenderObject.
Comment 1 Dirk Schulze 2010-01-05 14:24:04 PST 
Created attachment 45931 [details]
Don't use Renderer for SVGResource calculations

Don't use Renderer for SVGResource calculations.
Comment 2 WebKit Review Bot 2010-01-05 14:28:20 PST 
style-queue ran check-webkit-style on attachment 45931 [details] without any errors.
Comment 3 Nikolas Zimmermann 2010-01-06 19:09:13 PST 
Comment on attachment 45931 [details]
Don't use Renderer for SVGResource calculations

Postponed, as discussed with Dirk. Let's fix RenderSVGInline, and pass around renderers.
Comment 4 Dirk Schulze 2010-04-21 13:32:02 PDT 
The bounding box / repaint rect problems are fixed. Closing this bug now.