WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33223
[V8] Remove V8CustomBinding.cpp
https://bugs.webkit.org/show_bug.cgi?id=33223
Summary
[V8] Remove V8CustomBinding.cpp
Nate Chapin
Reported
2010-01-05 11:28:44 PST
There are a few functions declared in V8CustomBinding.h and implemented in V8CustomBinding.cpp that should find other homes. This is also as good a time as any to generate the custom access check header declarations, since some of those are implemented in V8CustomBinding.cpp and it's pretty straightforward to generate headers for them.
Attachments
patch
(26.43 KB, patch)
2010-01-05 13:21 PST
,
Nate Chapin
dglazkov
: review+
japhet
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nate Chapin
Comment 1
2010-01-05 13:21:51 PST
Created
attachment 45926
[details]
patch FYI, this change will break the Chromium downstream canaries.
WebKit Review Bot
Comment 2
2010-01-05 13:28:32 PST
style-queue ran check-webkit-style on
attachment 45926
[details]
without any errors.
Dimitri Glazkov (Google)
Comment 3
2010-01-05 14:34:30 PST
Comment on
attachment 45926
[details]
patch Rocking!
Nate Chapin
Comment 4
2010-01-07 09:39:36 PST
http://trac.webkit.org/changeset/52867
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug