Bug 33223 - [V8] Remove V8CustomBinding.cpp
Summary: [V8] Remove V8CustomBinding.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 32638
  Show dependency tree / graph
 
Reported: 2010-01-05 11:28 PST by Nate Chapin
Modified: 2010-01-07 09:39 PST (History)
1 user (show)

See Also:

Attachments
patch (26.43 KB, patch)
2010-01-05 13:21 PST, Nate Chapin 		dglazkov: review+
japhet: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-01-05 11:28:44 PST 
There are a few functions declared in V8CustomBinding.h and implemented in V8CustomBinding.cpp that should find other homes.  This is also as good a time as any to generate the custom access check header declarations, since some of those are implemented in V8CustomBinding.cpp and it's pretty straightforward to generate headers for them.
Comment 1 Nate Chapin 2010-01-05 13:21:51 PST 
Created attachment 45926 [details]
patch

FYI, this change will break the Chromium downstream canaries.
Comment 2 WebKit Review Bot 2010-01-05 13:28:32 PST 
style-queue ran check-webkit-style on attachment 45926 [details] without any errors.
Comment 3 Dimitri Glazkov (Google) 2010-01-05 14:34:30 PST 
Comment on attachment 45926 [details]
patch

Rocking!
Comment 4 Nate Chapin 2010-01-07 09:39:36 PST 
http://trac.webkit.org/changeset/52867