RESOLVED FIXED 33216
Add more WebViewDestruction tests 
https://bugs.webkit.org/show_bug.cgi?id=33216
Summary Add more WebViewDestruction tests
Adam Roben (:aroben)
Reported 2010-01-05 10:38:38 PST
Created attachment 45907 [details] Patch Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * WebKitAPITest/tests/WebViewDestruction.cpp: (WebKitAPITest::NoInitWithFrame): (WebKitAPITest::CloseThenDestroyViewWindow): (WebKitAPITest::DestroyViewWindowThenClose): (WebKitAPITest::DestroyHostWindow): (WebKitAPITest::DestroyHostWindowThenClose): (WebKitAPITest::CloseThenDestroyHostWindow): Added these tests that exercise tearing down a WebView in various ways, all of which we eventually want to have work. Some of them currently crash or leak. --- 2 files changed, 110 insertions(+), 6 deletions(-)
Attachments
Patch (5.33 KB, patch)
2010-01-05 10:38 PST, Adam Roben (:aroben) 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-01-05 10:43:32 PST
style-queue ran check-webkit-style on attachment 45907 [details] without any errors.
Eric Seidel (no email)
Comment 2 2010-01-05 12:23:38 PST
Comment on attachment 45907 [details] Patch LGTM. Needs a bug link. prepare-ChangeLog --bug 12355 will do that for you. bugzilla-tool submit-patch will also create the bug and update the ChangeLogs for you if that's easier in the future.
Adam Roben (:aroben)
Comment 3 2010-01-05 15:08:43 PST
Committed r52826: <http://trac.webkit.org/changeset/52826>
Note You need to log in before you can comment on or make changes to this bug.