Bug 33216 - Add more WebViewDestruction tests
Summary: Add more WebViewDestruction tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-05 10:38 PST by Adam Roben (:aroben)
Modified: 2010-01-05 15:08 PST (History)
2 users (show)

See Also:

Patch (5.33 KB, patch)
2010-01-05 10:38 PST, Adam Roben (:aroben)
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-01-05 10:38:38 PST
Created attachment 45907 [details]

Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* WebKitAPITest/tests/WebViewDestruction.cpp:
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.
 2 files changed, 110 insertions(+), 6 deletions(-)
Comment 1 WebKit Review Bot 2010-01-05 10:43:32 PST
style-queue ran check-webkit-style on attachment 45907 [details] without any errors.
Comment 2 Eric Seidel (no email) 2010-01-05 12:23:38 PST
Comment on attachment 45907 [details]

LGTM.  Needs a bug link.  prepare-ChangeLog --bug 12355 will do that for you.

bugzilla-tool submit-patch will also create the bug and update the ChangeLogs for you if that's easier in the future.
Comment 3 Adam Roben (:aroben) 2010-01-05 15:08:43 PST
Committed r52826: <http://trac.webkit.org/changeset/52826>