RESOLVED FIXED 33198
Reorganize, document and rename OS() platform macros. 
https://bugs.webkit.org/show_bug.cgi?id=33198
Summary Reorganize, document and rename OS() platform macros.
Maciej Stachowiak
Reported Tuesday, January 5, 2010 7:52:58 AM UTC
Reorganize, document and rename OS() platform macros.
Attachments
Patch (190.23 KB, patch)
2010-01-05 00:10 PST, Maciej Stachowiak 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 Tuesday, January 5, 2010 8:10:31 AM UTC
Created attachment 45868 [details] Patch
WebKit Review Bot
Comment 2 Tuesday, January 5, 2010 8:14:12 AM UTC
Attachment 45868 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/GraphicsContext3D.cpp:355: One space before end of line comments [whitespace/comments] [5] WebCore/platform/graphics/SimpleFontData.h:143: One space before end of line comments [whitespace/comments] [5] WebCore/platform/graphics/SimpleFontData.h:230: One space before end of line comments [whitespace/comments] [5] WebCore/plugins/PluginPackage.cpp:129: Should have a space between // and comment [whitespace/comments] [4] JavaScriptCore/runtime/DatePrototype.cpp:200: Extra space before ( in function call [whitespace/parens] [4] JavaScriptCore/wtf/Platform.h:320: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:321: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:382: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:384: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:385: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:386: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:387: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:388: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:389: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:390: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:909: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:910: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:911: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 21
Maciej Stachowiak
Comment 3 Tuesday, January 5, 2010 8:58:47 AM UTC
Committed r52791: <http://trac.webkit.org/changeset/52791>
Daniel Bates
Comment 4 Saturday, January 9, 2010 3:52:06 AM UTC
We should fix all the style errors found by the style bot, see bug #33417.
Note You need to log in before you can comment on or make changes to this bug.