Bug 33185 - [Chromium] Expose more DOM methods to support LayoutTests
Summary: [Chromium] Expose more DOM methods to support LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-04 15:40 PST by Darin Fisher (:fishd, Google)
Modified: 2010-01-05 00:00 PST (History)
4 users (show)

See Also:


Attachments
v1 patch (7.43 KB, patch)
2010-01-04 15:44 PST, Darin Fisher (:fishd, Google)
no flags Details | Formatted Diff | Diff
v2 patch (fixes gcc compilation error) (7.44 KB, patch)
2010-01-04 17:01 PST, Darin Fisher (:fishd, Google)
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-01-04 15:40:48 PST
[Chromium] Expose more DOM methods to support LayoutTests

Adding:
WebDocument::documentElement()
WebElement::innerText()
WebFrame::renderTreeAsText()
WebFrame::counterValueForElementById()
Comment 1 Darin Fisher (:fishd, Google) 2010-01-04 15:44:00 PST
Created attachment 45841 [details]
v1 patch
Comment 2 WebKit Review Bot 2010-01-04 15:47:09 PST
style-queue ran check-webkit-style on attachment 45841 [details] without any errors.
Comment 3 WebKit Review Bot 2010-01-04 16:25:13 PST
Attachment 45841 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/161779
Comment 4 Darin Fisher (:fishd, Google) 2010-01-04 17:01:01 PST
Created attachment 45845 [details]
v2 patch (fixes gcc compilation error)
Comment 5 WebKit Review Bot 2010-01-04 17:04:28 PST
style-queue ran check-webkit-style on attachment 45845 [details] without any errors.
Comment 6 Eric Seidel (no email) 2010-01-04 21:39:20 PST
Comment on attachment 45845 [details]
v2 patch (fixes gcc compilation error)

Looks sane to me.
Comment 7 WebKit Commit Bot 2010-01-04 21:49:04 PST
Comment on attachment 45845 [details]
v2 patch (fixes gcc compilation error)

Rejecting patch 45845 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
ceeded at 443 (offset 3 lines).
Hunk #6 succeeded at 467 (offset 3 lines).
patching file WebKit/chromium/src/WebDocument.cpp
patching file WebKit/chromium/src/WebElement.cpp
Hunk #1 succeeded at 82 with fuzz 1 (offset 12 lines).
patching file WebKit/chromium/src/WebFrameImpl.cpp
Hunk #2 succeeded at 357 (offset 1 line).
Hunk #3 succeeded at 1473 (offset 6 lines).
patching file WebKit/chromium/src/WebFrameImpl.h
Hunk #1 succeeded at 64 (offset 2 lines).
Hunk #2 succeeded at 161 (offset 3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/161872
Comment 8 Darin Fisher (:fishd, Google) 2010-01-05 00:00:49 PST
Landed as http://trac.webkit.org/changeset/52788