Bug 33156 - [V8] Generate runtime enabler declarations currently in V8CustomBinding.h.
Summary: [V8] Generate runtime enabler declarations currently in V8CustomBinding.h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 32638
  Show dependency treegraph
 
Reported: 2010-01-04 09:10 PST by Nate Chapin
Modified: 2010-01-04 10:47 PST (History)
1 user (show)

See Also:


Attachments
patch (9.98 KB, patch)
2010-01-04 09:39 PST, Nate Chapin
dglazkov: review+
japhet: commit-queue-
Details | Formatted Diff | Diff
patch2 (10.32 KB, patch)
2010-01-04 10:21 PST, Nate Chapin
dglazkov: review+
japhet: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-01-04 09:10:12 PST
See summary.  Most of the implementations live in V8DOMWindowCustom.cpp.
Comment 1 Nate Chapin 2010-01-04 09:39:13 PST
Created attachment 45803 [details]
patch
Comment 2 WebKit Review Bot 2010-01-04 09:41:18 PST
style-queue ran check-webkit-style on attachment 45803 [details] without any errors.
Comment 3 Dimitri Glazkov (Google) 2010-01-04 09:51:33 PST
Comment on attachment 45803 [details]
patch

ok. Is the perhaps a way to put generation logic into its own Perl function? It doesn't seem like there is, but I thought I'd ask.
Comment 4 Nate Chapin 2010-01-04 10:21:14 PST
Created attachment 45804 [details]
patch2

Perl code split into its own function.
Comment 5 WebKit Review Bot 2010-01-04 10:21:56 PST
style-queue ran check-webkit-style on attachment 45804 [details] without any errors.
Comment 6 Dimitri Glazkov (Google) 2010-01-04 10:36:21 PST
Comment on attachment 45804 [details]
patch2

> +sub GenerateRuntimeEnablerDeclarations

This should be GenerateHeaderRuntimeEnablerDeclarations. Or you could go with GenerateHeaderRuntimeEnabler.

Can fix on landing.
Comment 7 Nate Chapin 2010-01-04 10:47:38 PST
http://trac.webkit.org/changeset/52747