RESOLVED FIXED Bug 33145
Reorganize, document and rename CPU() platform macros. 
https://bugs.webkit.org/show_bug.cgi?id=33145
Summary Reorganize, document and rename CPU() platform macros.
Maciej Stachowiak
Reported 2010-01-04 03:04:07 PST
Reorganize, document and rename CPU() platform macros.
Attachments
Patch (76.84 KB, patch)
2010-01-04 03:09 PST, Maciej Stachowiak 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-01-04 03:09:48 PST
Created attachment 45791 [details] Patch
Adam Barth
Comment 2 2010-01-04 03:13:31 PST
Comment on attachment 45791 [details] Patch I agree that X86 is a CPU and not a PLATFORM
WebKit Review Bot
Comment 3 2010-01-04 03:13:52 PST
Attachment 45791 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Last 3072 characters of output: /indent] [3] JavaScriptCore/wtf/Platform.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:224: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:230: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:231: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:232: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:886: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:887: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:895: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:896: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/Platform.h:897: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 48
Maciej Stachowiak
Comment 4 2010-01-04 03:39:18 PST
Committed r52729: <http://trac.webkit.org/changeset/52729>
Note You need to log in before you can comment on or make changes to this bug.