Bug 33138 – ExecutableAllocatorSymbian appears to have buggy ARM version check

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Maciej Stachowiak]

ExecutableAllocatorSymbian has this code:

#if PLATFORM_ARM_ARCH(5)
    // The moving memory model (as used in ARMv5 and earlier platforms)                                      
    // on Symbian OS limits the number of chunks for each process to 16.                                     
    // To mitigate this limitation increase the pagesize to                                                  
    // allocate less of larger chunks.                                                                       
    ExecutableAllocator::pageSize = MOVING_MEM_PAGE_SIZE;
#else
    TInt page_size;
    UserHal::PageSizeInBytes(page_size);
    ExecutableAllocator::pageSize = page_size;
#endif

But PLATFORM_ARM_ARCH(5) checks for ARM achitecture greater than or equal to 5, not less than or equal to 5. I believe what is intended is this:

#if PLATFORM_ARM_ARCH(6)
    TInt page_size;
    UserHal::PageSizeInBytes(page_size);
    ExecutableAllocator::pageSize = page_size;
#else
    // The moving memory model (as used in ARMv5 and earlier platforms)                                      
    // on Symbian OS limits the number of chunks for each process to 16.                                     
    // To mitigate this limitation increase the pagesize to                                                  
    // allocate less of larger chunks.                                                                       
    ExecutableAllocator::pageSize = MOVING_MEM_PAGE_SIZE;
#endif

[Maciej Stachowiak]

I fixed this in r52729.