Bug 33135 - [bzt] Move steps to a submodule
Summary: [bzt] Move steps to a submodule
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-04 00:40 PST by Adam Barth
Modified: 2010-01-04 01:05 PST (History)
2 users (show)

See Also:


Attachments
Patch (117.62 KB, patch)
2010-01-04 00:40 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (119.82 KB, patch)
2010-01-04 00:43 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-04 00:40:03 PST
[bzt] Move steps to a submodule
Comment 1 Adam Barth 2010-01-04 00:40:58 PST
Created attachment 45773 [details]
Patch
Comment 2 Adam Barth 2010-01-04 00:43:31 PST
Created attachment 45774 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-01-04 00:45:38 PST
Comment on attachment 45774 [details]
Patch

I'm not sure the massive list of:
 29 from webkitpy.steps.applypatch import ApplyPatch
imports in __init__ is the right way to do this.  You should consider adding a FIXME there asking exactly that question.  But it seems to work...

OK.
Comment 4 Adam Barth 2010-01-04 00:47:51 PST
Fixenated r52714
Comment 5 Chris Jerdonek 2010-01-04 01:05:06 PST
(In reply to comment #4)
> Fixenated r52714

Looks like you need to update the path in test-webkit-scripts to test-webkitpy.

I will see if I can make that change here by updating my patch:

https://bugs.webkit.org/show_bug.cgi?id=33124