WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33135
[bzt] Move steps to a submodule
https://bugs.webkit.org/show_bug.cgi?id=33135
Summary
[bzt] Move steps to a submodule
Adam Barth
Reported
2010-01-04 00:40:03 PST
[bzt] Move steps to a submodule
Attachments
Patch
(117.62 KB, patch)
2010-01-04 00:40 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch
(119.82 KB, patch)
2010-01-04 00:43 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-01-04 00:40:58 PST
Created
attachment 45773
[details]
Patch
Adam Barth
Comment 2
2010-01-04 00:43:31 PST
Created
attachment 45774
[details]
Patch
Eric Seidel (no email)
Comment 3
2010-01-04 00:45:38 PST
Comment on
attachment 45774
[details]
Patch I'm not sure the massive list of: 29 from webkitpy.steps.applypatch import ApplyPatch imports in __init__ is the right way to do this. You should consider adding a FIXME there asking exactly that question. But it seems to work... OK.
Adam Barth
Comment 4
2010-01-04 00:47:51 PST
Fixenated
r52714
Chris Jerdonek
Comment 5
2010-01-04 01:05:06 PST
(In reply to
comment #4
)
> Fixenated
r52714
Looks like you need to update the path in test-webkit-scripts to test-webkitpy. I will see if I can make that change here by updating my patch:
https://bugs.webkit.org/show_bug.cgi?id=33124
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug