WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 33447
Bug 33134
Create a unit tested parsePatchHeader() subroutine for svn-apply and svn-unapply
https://bugs.webkit.org/show_bug.cgi?id=33134
Summary
Create a unit tested parsePatchHeader() subroutine for svn-apply and svn-unapply
Chris Jerdonek
Reported
2010-01-04 00:29:06 PST
Create a unit tested parsePatchHeader() subroutine for svn-apply and svn-unapply. In addition to providing more test coverage, this will result in more code sharing between svn-apply and svn-unapply. This affects the code in the main while(<>) loop of both scripts: while (<>) { s/([\n\r]+)$//mg; my $eol = $1; if (!defined($indexPath) && m#^diff --git a/#) { $filter = \&gitdiff2svndiff; } $_ = &$filter($_) if $filter; if (/^Index: (.+)/) { ... } if ($indexPath) { # Fix paths on diff, ---, and +++ lines to match preceding Index: line. s/^--- \S+/--- $indexPath/; if (/^--- .+\(from (\S+):\d+\)$/) { $copiedFromPath = $1; } if (s/^\+\+\+ \S+/+++ $indexPath/) { $indexPath = ""; }
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Jerdonek
Comment 1
2010-01-10 12:49:07 PST
*** This bug has been marked as a duplicate of
bug 33447
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug