Bug 33127 - Missing Test Outputs for MathML and License Updates
Summary: Missing Test Outputs for MathML and License Updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-03 20:27 PST by Alex Milowski
Modified: 2010-01-04 01:59 PST (History)
2 users (show)

See Also:


Attachments
The patch for updating the license header and adding the test outputs (73.99 KB, patch)
2010-01-03 20:27 PST, Alex Milowski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Milowski 2010-01-03 20:27:15 PST
Created attachment 45764 [details]
The patch for updating the license header and adding the test outputs

This patch just adds the missing tests outputs and updated the license header in preparation for other more substantial patches for MathML support.
Comment 1 WebKit Review Bot 2010-01-03 20:28:47 PST
style-queue ran check-webkit-style on attachment 45764 [details] without any errors.
Comment 2 Nikolas Zimmermann 2010-01-03 20:32:41 PST
Comment on attachment 45764 [details]
The patch for updating the license header and adding the test outputs

LGTM, r=me.
Comment 3 Nikolas Zimmermann 2010-01-03 20:42:18 PST
Comment on attachment 45764 [details]
The patch for updating the license header and adding the test outputs

Oops, I take the r+ back. Obviously the pixel test results can't be reproduced without the actual code that renders them. So there's no point in landing it before.
I got on the wrong track as the ChangeLog indicates that the pixel test results are missing, that's true, but the results that you created don't match trunk. You probably need to regenerate the results without your other patches applied (against a fresh trunk tree). Those could be landed, as they are really missing.
Comment 4 Alex Milowski 2010-01-03 20:49:59 PST
Comment on attachment 45764 [details]
The patch for updating the license header and adding the test outputs

The trunk can indeed generate the pixel test results.  You need to turn on the MathML code by enabling it via the --mathml option on build-webkit

The current trunk only supports styling via a very basic CSS stylesheet and is waiting for the rendering code.  This patch reduces the size of the patch for bug 29529.
Comment 5 Eric Seidel (no email) 2010-01-04 01:38:02 PST
Comment on attachment 45764 [details]
The patch for updating the license header and adding the test outputs

Given that you appear to be the sole author of this code this re-license seems OK.
Comment 6 WebKit Commit Bot 2010-01-04 01:59:11 PST
Comment on attachment 45764 [details]
The patch for updating the license header and adding the test outputs

Clearing flags on attachment: 45764

Committed r52721: <http://trac.webkit.org/changeset/52721>
Comment 7 WebKit Commit Bot 2010-01-04 01:59:18 PST
All reviewed patches have been landed.  Closing bug.