33122 – [Qt] RenderTheme: Missing support for native sliders

Bug 33122 - [Qt] RenderTheme: Missing support for native sliders

Summary: [Qt] RenderTheme: Missing support for native sliders

Attachments
Patch (10.09 KB, patch) 2010-01-03 13:21 PST, Jakub Wieczorek	no flags	Details \| Formatted Diff \| Diff
Patch (10.30 KB, patch) 2010-01-04 13:00 PST, Jakub Wieczorek	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jakub Wieczorek 2010-01-03 13:17:33 PST

QtWebKit needs to suppport painting native sliders to get <input type="range"> working.

Comment 1 Jakub Wieczorek 2010-01-03 13:21:46 PST

Created attachment 45758 [details]
Patch

Comment 2 WebKit Review Bot 2010-01-03 13:22:22 PST

style-queue ran check-webkit-style on attachment 45758 [details] without any errors.

Comment 3 Jakub Wieczorek 2010-01-04 11:22:54 PST

Comment on attachment 45758 [details]
Patch

Clearing review flag as I spotted a defect with vertical sliders with this patch.

Comment 4 Jakub Wieczorek 2010-01-04 13:00:00 PST

Created attachment 45822 [details]
Patch

Fixed RenderThemeQt::adjustSliderThumbSize() to work properly with vertical sliders.

Comment 5 WebKit Review Bot 2010-01-04 13:04:09 PST

style-queue ran check-webkit-style on attachment 45822 [details] without any errors.

Comment 6 Adam Treat 2010-01-05 13:04:50 PST

Comment on attachment 45822 [details]
Patch

Looks real good :)

r=me

Comment 7 WebKit Commit Bot 2010-01-06 19:37:58 PST

Comment on attachment 45822 [details]
Patch

Clearing flags on attachment: 45822

Committed r52896: <http://trac.webkit.org/changeset/52896>

Comment 8 WebKit Commit Bot 2010-01-06 19:38:03 PST

All reviewed patches have been landed.  Closing bug.