Bug 33120 - bugzilla-tool apply-patches fails with svn working directory
Summary: bugzilla-tool apply-patches fails with svn working directory
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-03 12:29 PST by David Kilzer (:ddkilzer)
Modified: 2010-01-03 13:11 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-01-03 12:29:59 PST 
With svn working directory:

$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

With git working directory:

$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
1 reviewed patch found on bug 33098.
Processing 1 patch from 1 bug.
Processing patch 45756 from bug 33098.
Comment 1 David Kilzer (:ddkilzer) 2010-01-03 12:43:40 PST 
I think this has to do with the fact that my svn working directory is a symlink:

svn co http://svn.webkit.org/repository/webkit/trunk /Volumes/Data/OpenSource
ln -s /Volumes/Data/OpenSource /Volumes/Data/WebKit
cd /Volumes/Data/WebKit
./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update
33098
Comment 2 David Kilzer (:ddkilzer) 2010-01-03 12:47:58 PST 
(In reply to comment #1)
> I think this has to do with the fact that my svn working directory is a
> symlink:
> 
> svn co http://svn.webkit.org/repository/webkit/trunk /Volumes/Data/OpenSource
> ln -s /Volumes/Data/OpenSource /Volumes/Data/WebKit
> cd /Volumes/Data/WebKit
> ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update
> 33098

Nope, this still happens when changing directory to ../OpenSource:

$ cd ../OpenSource/
$ ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
Comment 3 Adam Barth 2010-01-03 12:52:40 PST 
Investigating.
Comment 4 Adam Barth 2010-01-03 12:54:03 PST 
Works for me:

abarth@quadzen:~/svn/webkit3$  ./WebKitTools/Scripts/bugzilla-tool apply-patches --no-clean --no-update 33098
Fetching: https://bugs.webkit.org/show_bug.cgi?id=33098&ctype=xml
1 reviewed patch found on bug 33098.
Processing 1 patch from 1 bug.
Processing patch 45756 from bug 33098.

Is there anything special about your webkit setup or checkout?
Comment 5 David Kilzer (:ddkilzer) 2010-01-03 13:11:06 PST 
The immediate problem was a missing "--location" switch when using curl to download the patch, but I think WebKitTools/Scripts was stuck on an old branch.  Marking RESOLVED/INVALID.