Bug 33114 - [Qt] Reimplement EventSender::leapForward
Summary: [Qt] Reimplement EventSender::leapForward
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Yael
Keywords: Qt
Depends on:
Blocks: 31332
  Show dependency treegraph
Reported: 2010-01-02 13:46 PST by Yael
Modified: 2010-01-05 11:44 PST (History)
6 users (show)

See Also:

Patch. (7.65 KB, patch)
2010-01-02 14:03 PST, Yael
no flags Details | Formatted Diff | Diff
Patch v2 (7.80 KB, patch)
2010-01-05 07:23 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-01-02 13:46:13 PST
The Qt implementation of EventSender::leapForward is saving the timeout value in a variable, but not waiting for that period of time.
This is important for e.g. Drag & Drop tests.
Comment 1 Yael 2010-01-02 14:03:24 PST
Created attachment 45750 [details]

This is the second part of the patch aiming to fix https://bugs.webkit.org/show_bug.cgi?id=31332. 
It is based on the windows implementation of eventSender::leapForward.
Comment 2 WebKit Review Bot 2010-01-02 14:07:50 PST
style-queue ran check-webkit-style on attachment 45750 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-03 18:23:01 PST
I still don't really understand leapForward.
Comment 4 Yael 2010-01-05 07:23:07 PST
Created attachment 45888 [details]
Patch v2

Updated the comment and renamed m_mouseButtonDown to m_mouseButtonPressed as suggested by Kenneth on IRC.
Comment 5 WebKit Review Bot 2010-01-05 07:29:22 PST
style-queue ran check-webkit-style on attachment 45888 [details] without any errors.
Comment 6 Kenneth Rohde Christiansen 2010-01-05 08:23:52 PST
Comment on attachment 45888 [details]
Patch v2

Talked with Yael on IRC and she will commit a patch with some minor changes.
Comment 7 WebKit Commit Bot 2010-01-05 11:44:09 PST
Comment on attachment 45888 [details]
Patch v2

Clearing flags on attachment: 45888

Committed r52816: <http://trac.webkit.org/changeset/52816>
Comment 8 WebKit Commit Bot 2010-01-05 11:44:15 PST
All reviewed patches have been landed.  Closing bug.