Bug 33112 - Add #error for unsupported platforms in JITStubs.cpp
Summary: Add #error for unsupported platforms in JITStubs.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-02 12:46 PST by Patrick R. Gansterer
Modified: 2010-01-05 10:36 PST (History)
5 users (show)

See Also:


Attachments
The patch (X86 and X86_64) (1.65 KB, patch)
2010-01-02 12:47 PST, Patrick R. Gansterer
darin: review-
Details | Formatted Diff | Diff
The patch (X86 only) (1.61 KB, patch)
2010-01-02 12:54 PST, Patrick R. Gansterer
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
The patch (1.58 KB, patch)
2010-01-05 02:32 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-01-02 12:46:51 PST
see patch
Comment 1 Patrick R. Gansterer 2010-01-02 12:47:58 PST
Created attachment 45745 [details]
The patch (X86 and X86_64)
Comment 2 WebKit Review Bot 2010-01-02 12:50:10 PST
Attachment 45745 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:394:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1
Comment 3 Patrick R. Gansterer 2010-01-02 12:54:45 PST
Created attachment 45746 [details]
The patch (X86 only)

I'm not sure if the MSVC code is X86 only or X86+X86_64.

The patches are exclusive.
Comment 4 WebKit Review Bot 2010-01-02 12:55:54 PST
Attachment 45746 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:394:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1
Comment 5 WebKit Commit Bot 2010-01-04 08:24:39 PST
Comment on attachment 45746 [details]
The patch (X86 only)

Rejecting patch 45746 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1
patching file JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file JavaScriptCore/jit/JITStubs.cpp
Hunk #2 FAILED at 390.
Hunk #4 FAILED at 698.
2 out of 4 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITStubs.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/161547
Comment 6 Patrick R. Gansterer 2010-01-05 02:32:19 PST
Created attachment 45875 [details]
The patch

Updated patch to fit the new CPU() macros.
Comment 7 WebKit Review Bot 2010-01-05 02:34:31 PST
Attachment 45875 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:400:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1
Comment 8 WebKit Commit Bot 2010-01-05 10:36:53 PST
Comment on attachment 45875 [details]
The patch

Clearing flags on attachment: 45875

Committed r52806: <http://trac.webkit.org/changeset/52806>
Comment 9 WebKit Commit Bot 2010-01-05 10:36:59 PST
All reviewed patches have been landed.  Closing bug.