RESOLVED FIXED 33111
Mark more filter effect as alphaImage if possible 
https://bugs.webkit.org/show_bug.cgi?id=33111
Summary Mark more filter effect as alphaImage if possible
Dirk Schulze
Reported 2010-01-02 11:54:20 PST
Mark more filter effect as alphaImage if possible.
Attachments
Mark more effects as alphaImage if previous effect is alphaImage (3.19 KB, patch)
2010-01-02 12:31 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Mark more effects as alphaImage if previous effect is alphaImage (3.22 KB, patch)
2010-01-02 14:27 PST, Dirk Schulze 		zimmermann: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-01-02 12:31:53 PST
Created attachment 45744 [details] Mark more effects as alphaImage if previous effect is alphaImage Mark more effects as alphaImage if previous effect is alphaImage.
WebKit Review Bot
Comment 2 2010-01-02 12:34:38 PST
style-queue ran check-webkit-style on attachment 45744 [details] without any errors.
WebKit Review Bot
Comment 3 2010-01-02 12:40:15 PST
Attachment 45744 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/159572
Dirk Schulze
Comment 4 2010-01-02 14:27:17 PST
Created attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage should build on qt now.
WebKit Review Bot
Comment 5 2010-01-02 14:28:16 PST
style-queue ran check-webkit-style on attachment 45751 [details] without any errors.
Nikolas Zimmermann
Comment 6 2010-01-02 16:33:05 PST
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage LGTM, r=me.
WebKit Commit Bot
Comment 7 2010-01-02 16:42:11 PST
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 97.47s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/160510
Dirk Schulze
Comment 8 2010-01-03 07:33:38 PST
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage The code doesn't touch anything else than SVG Filters.
WebKit Commit Bot
Comment 9 2010-01-03 07:41:33 PST
Comment on attachment 45751 [details] Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 79.05s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/161006
Dirk Schulze
Comment 10 2010-01-03 09:42:44 PST
(In reply to comment #9) > (From update of attachment 45751 [details]) > Rejecting patch 45751 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests > Testing 11861 test cases. > fast/canvas/webgl/index-validation-copies-indices.html -> failed > > Exiting early after 1 failures. 5000 tests run. > 79.05s total testing time > > 4999 test cases (99%) succeeded > 1 test case (<1%) had incorrect layout > 1 test case (<1%) had stderr output > > Full output: http://webkit-commit-queue.appspot.com/results/161006 Hehe. There is no test with this name in the repository :-P
Dirk Schulze
Comment 11 2010-01-03 09:57:24 PST
landed in r52689. Closing bug.
Eric Seidel (no email)
Comment 12 2010-01-03 17:42:31 PST
This patch was a victim of bug 28603.
Note You need to log in before you can comment on or make changes to this bug.