Bug 33111 - Mark more filter effect as alphaImage if possible
Summary: Mark more filter effect as alphaImage if possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-02 11:54 PST by Dirk Schulze
Modified: 2010-01-03 17:42 PST (History)
4 users (show)

See Also:


Attachments
Mark more effects as alphaImage if previous effect is alphaImage (3.19 KB, patch)
2010-01-02 12:31 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff
Mark more effects as alphaImage if previous effect is alphaImage (3.22 KB, patch)
2010-01-02 14:27 PST, Dirk Schulze
zimmermann: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-01-02 11:54:20 PST
Mark more filter effect as alphaImage if possible.
Comment 1 Dirk Schulze 2010-01-02 12:31:53 PST
Created attachment 45744 [details]
Mark more effects as alphaImage if previous effect is alphaImage

Mark more effects as alphaImage if previous effect is alphaImage.
Comment 2 WebKit Review Bot 2010-01-02 12:34:38 PST
style-queue ran check-webkit-style on attachment 45744 [details] without any errors.
Comment 3 WebKit Review Bot 2010-01-02 12:40:15 PST
Attachment 45744 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/159572
Comment 4 Dirk Schulze 2010-01-02 14:27:17 PST
Created attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage

should build on qt now.
Comment 5 WebKit Review Bot 2010-01-02 14:28:16 PST
style-queue ran check-webkit-style on attachment 45751 [details] without any errors.
Comment 6 Nikolas Zimmermann 2010-01-02 16:33:05 PST
Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage

LGTM, r=me.
Comment 7 WebKit Commit Bot 2010-01-02 16:42:11 PST
Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage

Rejecting patch 45751 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
Testing 11861 test cases.
fast/canvas/webgl/index-validation-copies-indices.html -> failed

Exiting early after 1 failures. 5000 tests run.
97.47s total testing time

4999 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/160510
Comment 8 Dirk Schulze 2010-01-03 07:33:38 PST
Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage

The code doesn't touch anything else than SVG Filters.
Comment 9 WebKit Commit Bot 2010-01-03 07:41:33 PST
Comment on attachment 45751 [details]
Mark more effects as alphaImage if previous effect is alphaImage

Rejecting patch 45751 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
Testing 11861 test cases.
fast/canvas/webgl/index-validation-copies-indices.html -> failed

Exiting early after 1 failures. 5000 tests run.
79.05s total testing time

4999 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/161006
Comment 10 Dirk Schulze 2010-01-03 09:42:44 PST
(In reply to comment #9)
> (From update of attachment 45751 [details])
> Rejecting patch 45751 from commit-queue.
> 
> Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari',
> '--exit-after-n-failures=1', '--quiet']" exit_code: 1
> Running build-dumprendertree
> Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
> Testing 11861 test cases.
> fast/canvas/webgl/index-validation-copies-indices.html -> failed
> 
> Exiting early after 1 failures. 5000 tests run.
> 79.05s total testing time
> 
> 4999 test cases (99%) succeeded
> 1 test case (<1%) had incorrect layout
> 1 test case (<1%) had stderr output
> 
> Full output: http://webkit-commit-queue.appspot.com/results/161006

Hehe. There is no test with this name in the repository :-P
Comment 11 Dirk Schulze 2010-01-03 09:57:24 PST
landed in r52689. Closing bug.
Comment 12 Eric Seidel (no email) 2010-01-03 17:42:31 PST
This patch was a victim of bug 28603.