Bug 33110 - Add cacheFlush support for WinCE
Summary: Add cacheFlush support for WinCE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-02 11:44 PST by Patrick R. Gansterer
Modified: 2010-01-04 11:25 PST (History)
5 users (show)

See Also:


Attachments
Add cacheFlush support for WinCE (1.57 KB, patch)
2010-01-02 11:48 PST, Patrick R. Gansterer
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-01-02 11:44:34 PST
Maybe the CACHE_SYNC_ALL can be changed to something else.
see http://msdn.microsoft.com/en-us/library/aa450787.aspx

Pkfuncs.h is only aviable via Platform Builder, but CacheRangeFlush is present in coredll.lib.
Comment 1 Patrick R. Gansterer 2010-01-02 11:48:18 PST
Created attachment 45743 [details]
Add cacheFlush support for WinCE
Comment 2 WebKit Review Bot 2010-01-02 11:48:40 PST
style-queue ran check-webkit-style on attachment 45743 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-03 18:17:34 PST
This looks sane to me, but Oliver or Gavin would know better.
Comment 4 Darin Adler 2010-01-04 08:58:53 PST
Comment on attachment 45743 [details]
Add cacheFlush support for WinCE

Seems OK if including <pkfuncs.h> is impractical.

r=me
Comment 5 WebKit Commit Bot 2010-01-04 09:21:06 PST
Comment on attachment 45743 [details]
Add cacheFlush support for WinCE

Clearing flags on attachment: 45743

Committed r52743: <http://trac.webkit.org/changeset/52743>
Comment 6 WebKit Commit Bot 2010-01-04 09:21:17 PST
All reviewed patches have been landed.  Closing bug.