Bug 33107 - [XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and post-from-iframe.html
Summary: [XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and pos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: XSSAuditor
Depends on:
Blocks: 33109
  Show dependency tree / graph
 
Reported: 2010-01-02 10:41 PST by Daniel Bates
Modified: 2010-01-02 11:55 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2010-01-02 10:47 PST, Daniel Bates 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-01-02 10:41:43 PST 
We should remove the use of window.setTimeout from the tests:

/LayoutTests/http/tests/security/xssAuditor/get-from-iframe.html
/LayoutTests/http/tests/security/xssAuditor/post-from-iframe.html

The JavaScript function window.setTimeout has been suspected to be the cause of test flakiness on the bots. Instead of using setTimeout we can modify the script echo-intertag.pl (called by these tests) to optionally call layoutTestController.notifyDone().
Comment 1 Daniel Bates 2010-01-02 10:47:27 PST 
Created attachment 45741 [details]
Patch

No functionality was changed, so no new tests.
Comment 2 WebKit Review Bot 2010-01-02 10:52:31 PST 
style-queue ran check-webkit-style on attachment 45741 [details] without any errors.
Comment 3 Adam Barth 2010-01-02 11:27:24 PST 
Comment on attachment 45741 [details]
Patch

excellent
Comment 4 Daniel Bates 2010-01-02 11:55:55 PST 
Committed in <http://trac.webkit.org/changeset/52687>.