WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33107
[XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and post-from-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=33107
Summary
[XSSAuditor] Remove window.setTimeout from tests get-from-iframe.html and pos...
Daniel Bates
Reported
2010-01-02 10:41:43 PST
We should remove the use of window.setTimeout from the tests: /LayoutTests/http/tests/security/xssAuditor/get-from-iframe.html /LayoutTests/http/tests/security/xssAuditor/post-from-iframe.html The JavaScript function window.setTimeout has been suspected to be the cause of test flakiness on the bots. Instead of using setTimeout we can modify the script echo-intertag.pl (called by these tests) to optionally call layoutTestController.notifyDone().
Attachments
Patch
(3.39 KB, patch)
2010-01-02 10:47 PST
,
Daniel Bates
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2010-01-02 10:47:27 PST
Created
attachment 45741
[details]
Patch No functionality was changed, so no new tests.
WebKit Review Bot
Comment 2
2010-01-02 10:52:31 PST
style-queue ran check-webkit-style on
attachment 45741
[details]
without any errors.
Adam Barth
Comment 3
2010-01-02 11:27:24 PST
Comment on
attachment 45741
[details]
Patch excellent
Daniel Bates
Comment 4
2010-01-02 11:55:55 PST
Committed in <
http://trac.webkit.org/changeset/52687
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug