Bug 33097 - [Qt] Clean up File menu in QtLauncher and QGVLauncher and make keyboard shortcuts similar to Safari
Summary: [Qt] Clean up File menu in QtLauncher and QGVLauncher and make keyboard short...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-01 15:45 PST by Daniel Bates
Modified: 2010-01-04 00:44 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.75 KB, patch)
2010-01-01 15:51 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-01-01 15:45:53 PST 
We should reorganize the File menu in QtLauncher and QGVLauncher as well as assign keyboard shortcuts that are similar to Safari. We should also add a "Quit" menu option that closes all open windows.
Comment 1 Daniel Bates 2010-01-01 15:51:06 PST 
Created attachment 45736 [details]
Patch

Added a "Quit" menu option to close all open windows. Also, renamed the Tools menu to Develop to conform to the menu with the same name in Safari that contains the Show Web Inspector option.
Comment 2 WebKit Review Bot 2010-01-01 15:54:02 PST 
style-queue ran check-webkit-style on attachment 45736 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-02 12:20:54 PST 
Comment on attachment 45736 [details]
Patch

Looks fine by my eyes.  But a Qt person should probably r+ this.

I assume that all of these QKeySequence's are available in all versions of Qt that WKQt targets?  I seem to remember another patch with QKeySequence's where they were guarded or something.
Comment 4 Eric Seidel (no email) 2010-01-03 18:16:46 PST 
Comment on attachment 45736 [details]
Patch

r+'ing this change to the test tool seems very low risk.  The change looks fine to me.  We can always roll this out if Dan and I both missed something.
Comment 5 Eric Seidel (no email) 2010-01-03 18:48:14 PST 
Attachment 45736 [details] was posted by a committer and has review+, assigning to Daniel Bates for commit.
Comment 6 Daniel Bates 2010-01-04 00:44:13 PST 
Comment on attachment 45736 [details]
Patch

Clearing flags on attachment: 45736

Committed r52713: <http://trac.webkit.org/changeset/52713>
Comment 7 Daniel Bates 2010-01-04 00:44:20 PST 
All reviewed patches have been landed.  Closing bug.