Bug 33095 - SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged
Summary: SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 68469 26389
  Show dependency tree / graph
 
Reported: 2010-01-01 07:54 PST by Dirk Schulze
Modified: 2014-05-12 05:54 PDT (History)
1 user (show)

See Also:

Attachments
Preperation of svgAttrChanged pactch (19.94 KB, patch)
2010-01-01 14:45 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-01-01 07:54:59 PST 
SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged.
Comment 1 Dirk Schulze 2010-01-01 14:45:00 PST 
Created attachment 45735 [details]
Preperation of  svgAttrChanged pactch

Preperation of  svgAttrChanged pactch. Save reference to the ResourceFilter to invalidate if one effect changes Attribute. Next patch will add svgAttributeChanged and dynamic-update tests.
It is also possible to create more than one Resource per Id. This helps to fix bug 19388.
Comment 2 WebKit Review Bot 2010-01-01 14:57:27 PST 
style-queue ran check-webkit-style on attachment 45735 [details] without any errors.
Comment 3 Dirk Schulze 2010-01-02 05:16:38 PST 
Comment on attachment 45735 [details]
Preperation of  svgAttrChanged pactch

Got ASSERTION FAILED: object
(SVGFilterElement.cpp:190 virtual WebCore::SVGResource* WebCore::SVGFilterElement::canvasResource(const WebCore::RenderObject*))

in Debug build.
Comment 4 Dirk Schulze 2010-01-02 06:38:57 PST 
(In reply to comment #3)
> (From update of attachment 45735 [details])
> Got ASSERTION FAILED: object
> (SVGFilterElement.cpp:190 virtual WebCore::SVGResource*
> WebCore::SVGFilterElement::canvasResource(const WebCore::RenderObject*))
> 
> in Debug build.

This problem does only appear during LayoutTests. It also looks like a general bug in  RenderSVGTextToTree. See bug 33105
Comment 5 Dirk Schulze 2010-01-02 16:59:28 PST 
After talking with Niko on IRC it turns out, that SVGStyledElement is doing the job already. All effects and the filter itself inherit from SVGStyledElement. Closing this bug now.