Bug 33090 - AX: any DIV with an aria role should not be ignored
: AX: any DIV with an aria role should not be ignored
Status: RESOLVED FIXED
: WebKit
Accessibility
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-12-31 19:37 PST by
Modified: 2010-01-04 14:47 PST (History)


Attachments
patch (4.22 KB, patch)
2009-12-31 20:59 PST, chris fleizach
darin: review+
commit-queue: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-31 19:37:12 PST
a DIV with an aria role should not be ignored by accessibility
------- Comment #1 From 2009-12-31 20:59:50 PST -------
Created an attachment (id=45727) [details]
patch
------- Comment #2 From 2009-12-31 21:01:40 PST -------
style-queue ran check-webkit-style on attachment 45727 [details] without any errors.
------- Comment #3 From 2010-01-04 10:15:18 PST -------
(From update of attachment 45727 [details])
Rejecting patch 45727 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11862 test cases.
svg/W3C-SVG-1.1/animate-elem-30-t.svg -> crashed

Exiting early after 1 failures. 9854 tests run.
475.20s total testing time

9853 test cases (99%) succeeded
1 test case (<1%) crashed
7 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/161591
------- Comment #4 From 2010-01-04 10:17:31 PST -------
seems unlikely this patch was the culprit

svg/W3C-SVG-1.1/animate-elem-30-t.svg -> crashed
------- Comment #5 From 2010-01-04 10:55:19 PST -------
http://trac.webkit.org/changeset/52748
------- Comment #6 From 2010-01-04 13:14:51 PST -------
Looks like http://trac.webkit.org/changeset/52746 had landed and the bots were behind.   Due to bug 30098 we didn't notice the bots were behind when running the commit-queue.  I'll move bug 30098 further up my priority list. :(

Sorry for the trouble.
------- Comment #7 From 2010-01-04 14:47:01 PST -------
> I'll move bug 30098 further up my priority list. :(

I just posted a patch to fix that bug.