Bug 33087 - [V8] Separate DOMWrapperWorld from V8IsolatedWorld
Summary: [V8] Separate DOMWrapperWorld from V8IsolatedWorld
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 10:27 PST by Adam Barth
Modified: 2010-01-05 11:04 PST (History)
2 users (show)

See Also:


Attachments
Patch (53.47 KB, patch)
2009-12-31 10:33 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (53.47 KB, patch)
2009-12-31 10:40 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch with style fixes (53.54 KB, patch)
2009-12-31 10:45 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch with linux build fix (54.02 KB, patch)
2009-12-31 11:18 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-31 10:27:55 PST
[V8] Separate DOMWrapperWorld from V8IsolatedWorld
Comment 1 Adam Barth 2009-12-31 10:33:21 PST
Created attachment 45717 [details]
Patch
Comment 2 Adam Barth 2009-12-31 10:35:11 PST
Strange that the diff has V8IsolatedContext.* twice.  My working copy seems ok though.  Must be svn's way of handling renames...
Comment 3 Adam Barth 2009-12-31 10:40:17 PST
Created attachment 45718 [details]
Patch
Comment 4 WebKit Review Bot 2009-12-31 10:40:57 PST
Attachment 45718 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8IsolatedContext.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.cpp:64:  context_scope is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/v8/V8IsolatedContext.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:40:  One space before end of line comments  [whitespace/comments] [5]
WebCore/bindings/v8/V8IsolatedContext.h:73:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/bindings/v8/V8IsolatedContext.h:107:  isolated_world is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
WebCore/bindings/v8/MainThreadDOMData.cpp:57:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 8
Comment 5 Adam Barth 2009-12-31 10:45:22 PST
Created attachment 45719 [details]
Patch with style fixes
Comment 6 WebKit Review Bot 2009-12-31 10:47:33 PST
Attachment 45719 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8IsolatedContext.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.cpp:64:  context_scope is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 2
Comment 7 WebKit Review Bot 2009-12-31 11:09:04 PST
Attachment 45719 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/155213
Comment 8 Adam Barth 2009-12-31 11:18:34 PST
Created attachment 45720 [details]
Patch with linux build fix
Comment 9 Adam Barth 2009-12-31 11:20:48 PST
This style failure seems necessary to get the patch to build on linux:
readability/comparison_to_zero
Comment 10 WebKit Review Bot 2009-12-31 11:23:41 PST
Attachment 45720 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for reading
WebCore/bindings/v8/MainThreadDOMData.cpp:57:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 1
Comment 11 Dimitri Glazkov (Google) 2010-01-05 09:20:13 PST
Comment on attachment 45720 [details]
Patch with linux build fix

ok. I wish this patch could've been smaller. I am pretty sure if there was a bug there somewhere, there's no way I'd see it.
Comment 12 Adam Barth 2010-01-05 10:29:00 PST
Comment on attachment 45720 [details]
Patch with linux build fix

Thanks for the review.  I'll try to do these changes in smaller pieces in the future.
Comment 13 Adam Barth 2010-01-05 11:04:32 PST
Comment on attachment 45720 [details]
Patch with linux build fix

Clearing flags on attachment: 45720

Committed r52811: <http://trac.webkit.org/changeset/52811>
Comment 14 Adam Barth 2010-01-05 11:04:41 PST
All reviewed patches have been landed.  Closing bug.