I change in JavaScriptCore/runtime/Structure.h prompted a rebuild of WebCore/html/canvas/CanvasRenderingContext2D.cpp. I found this a bit strange and after looking into it, it turned out that this dependency can be easily broken by not including Frame.h in WebCore/html/canvas/CanvasRenderingContext2D.cpp (which is the only file under WebCore/html/canvas which includes Frame.h). Here is the ChangeSet that removed the Frame dependency but failed to remove the Frame.h include - http://trac.webkit.org/changeset/21749/trunk/WebCore/html/CanvasRenderingContext2D.cpp.
Created attachment 45711 [details] proposed patch
style-queue ran check-webkit-style on attachment 45711 [details] without any errors.
Comment on attachment 45711 [details] proposed patch LGTM
Comment on attachment 45711 [details] proposed patch Thanks for the review !
Comment on attachment 45711 [details] proposed patch Clearing flags on attachment: 45711 Committed r52682: <http://trac.webkit.org/changeset/52682>
All reviewed patches have been landed. Closing bug.
just a note - unrelated bot failure on "SnowLeopard Intel Leaks" bot; as the the bot seemed to run out of disk space. Failed to open temp file in /var/folders/Qe/QejWyO1eEHebyJWD9dE3TU+++TM/-Tmp-//, error: No space left on device Command /Developer/usr/bin/g++-4.2 failed with exit code 1 Command /Developer/usr/bin/g++-4.2 failed with exit code 1 ** BUILD FAILED ** The following build commands failed: WebKit: Ld /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit normal x86_64 (1 failure)
Cherry-picked into qtwebkit-4.6 as 75ab03a8db2cc638957ba2c3c7accfb7723eebb1