Bug 33082 - Do not include Frame.h under WebCore/html/canvas
Summary: Do not include Frame.h under WebCore/html/canvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32988
  Show dependency treegraph
 
Reported: 2009-12-31 08:36 PST by Laszlo Gombos
Modified: 2010-01-05 00:55 PST (History)
3 users (show)

See Also:


Attachments
proposed patch (1.04 KB, patch)
2009-12-31 08:39 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-12-31 08:36:42 PST
I change in JavaScriptCore/runtime/Structure.h prompted a rebuild of WebCore/html/canvas/CanvasRenderingContext2D.cpp. I found this a bit strange and after looking into it, it turned out that this dependency can be easily broken by not including Frame.h in WebCore/html/canvas/CanvasRenderingContext2D.cpp (which is the only file under WebCore/html/canvas which includes Frame.h).

Here is the ChangeSet that removed the Frame dependency but failed to remove the Frame.h include - http://trac.webkit.org/changeset/21749/trunk/WebCore/html/CanvasRenderingContext2D.cpp.
Comment 1 Laszlo Gombos 2009-12-31 08:39:08 PST
Created attachment 45711 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-31 08:42:33 PST
style-queue ran check-webkit-style on attachment 45711 [details] without any errors.
Comment 3 Kenneth Rohde Christiansen 2009-12-31 09:25:47 PST
Comment on attachment 45711 [details]
proposed patch

LGTM
Comment 4 Laszlo Gombos 2009-12-31 09:56:15 PST
Comment on attachment 45711 [details]
proposed patch

Thanks for the review !
Comment 5 WebKit Commit Bot 2009-12-31 10:07:13 PST
Comment on attachment 45711 [details]
proposed patch

Clearing flags on attachment: 45711

Committed r52682: <http://trac.webkit.org/changeset/52682>
Comment 6 WebKit Commit Bot 2009-12-31 10:07:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Laszlo Gombos 2009-12-31 10:14:58 PST
just a note - unrelated bot failure on "SnowLeopard Intel Leaks" bot; as the the bot seemed to run out of disk space.

Failed to open temp file in /var/folders/Qe/QejWyO1eEHebyJWD9dE3TU+++TM/-Tmp-//, error: No space left on device
Command /Developer/usr/bin/g++-4.2 failed with exit code 1
Command /Developer/usr/bin/g++-4.2 failed with exit code 1
** BUILD FAILED **


The following build commands failed:
WebKit:
	Ld /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit normal x86_64
(1 failure)
Comment 8 Simon Hausmann 2010-01-05 00:55:33 PST
Cherry-picked into qtwebkit-4.6 as 75ab03a8db2cc638957ba2c3c7accfb7723eebb1