Some tests in LayoutTests/animations/ depend of 3D rendering. I attach a patch where I create a 3d directory in animations and I move the tests dependent of 3D into.
Created attachment 45710 [details] create 3d directory and move tests dependent of 3d in this directory.
style-queue ran check-webkit-style on attachment 45710 [details] without any errors.
Comment on attachment 45710 [details] create 3d directory and move tests dependent of 3d in this directory. Rejecting patch 45710 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11855 test cases. animations/3d/change-transform-in-end-event.html -> new (results generated in /Users/eseidel/Projects/CommitQueueSVN/LayoutTests/platform/mac/animations/3d) Exiting early after 1 failures. 109 tests run. 13.18s total testing time 108 test cases (99%) succeeded 1 test case (<1%) was new 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/155179
Created attachment 45731 [details] move animation test dependent of 3D in 3d directories and move also the expected generated move the expected for mac and Qt to 3d directory in platform/"mac/qt"/animations/3d
Comment on attachment 45731 [details] move animation test dependent of 3D in 3d directories and move also the expected generated Rejecting patch 45731 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Fraser', '--force']" exit_code: 1 svn: Path 'LayoutTests/animations/3d/change-transform-in-end-event.html' is not a directory Failed to svn copy LayoutTests/animations/change-transform-in-end-event.html LayoutTests/animations/3d/change-transform-in-end-event.html. at /Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply line 456. Full output: http://webkit-commit-queue.appspot.com/results/155915
I don't understand the problem, I use this : WebKitTools/Scripts/svn-apply --reviewer 'Simon Fraser' --force layoutTests_animation3D.patch after checkout again the webkit sources and I haven't problem to apply the patch. Can you explain me what I can change to fix this problem ?
I expect these failures were related to bug 28603.
Comment on attachment 45710 [details] create 3d directory and move tests dependent of 3d in this directory. Rejecting patch 45710 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11857 test cases. animations/3d/change-transform-in-end-event.html -> new (results generated in /Users/eseidel/Projects/CommitQueue/LayoutTests/platform/mac/animations/3d) Exiting early after 1 failures. 109 tests run. 13.52s total testing time 108 test cases (99%) succeeded 1 test case (<1%) was new 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/162136
change-transform-in-end-event.html is simply missing -expected.txt results. That' why the first patch is failing to commit properly.
Comment on attachment 45731 [details] move animation test dependent of 3D in 3d directories and move also the expected generated Clearing flags on attachment: 45731 Committed r52694: <http://trac.webkit.org/changeset/52694>
Looks like this was landed. Closing.