Bug 33081 - layoutTest animation 3D
Summary: layoutTest animation 3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 08:26 PST by Mario Bensi
Modified: 2010-01-06 09:53 PST (History)
4 users (show)

See Also:


Attachments
create 3d directory and move tests dependent of 3d in this directory. (19.75 KB, patch)
2009-12-31 08:30 PST, Mario Bensi
simon.fraser: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
move animation test dependent of 3D in 3d directories and move also the expected generated (63.01 KB, patch)
2010-01-01 03:22 PST, Mario Bensi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Bensi 2009-12-31 08:26:44 PST
Some tests in LayoutTests/animations/ depend of 3D rendering.

I attach a patch where I create a 3d directory in animations and I move the tests dependent of 3D into.
Comment 1 Mario Bensi 2009-12-31 08:30:14 PST
Created attachment 45710 [details]
create 3d directory and move tests dependent of 3d in this directory.
Comment 2 WebKit Review Bot 2009-12-31 08:32:05 PST
style-queue ran check-webkit-style on attachment 45710 [details] without any errors.
Comment 3 WebKit Commit Bot 2009-12-31 10:34:04 PST
Comment on attachment 45710 [details]
create 3d directory and move tests dependent of 3d in this directory.

Rejecting patch 45710 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
Testing 11855 test cases.
animations/3d/change-transform-in-end-event.html -> new (results generated in /Users/eseidel/Projects/CommitQueueSVN/LayoutTests/platform/mac/animations/3d)

Exiting early after 1 failures. 109 tests run.
13.18s total testing time

108 test cases (99%) succeeded
1 test case (<1%) was new
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/155179
Comment 4 Mario Bensi 2010-01-01 03:22:07 PST
Created attachment 45731 [details]
move animation test dependent of 3D in 3d directories and move also the expected generated

move the expected for mac and Qt to 3d directory in platform/"mac/qt"/animations/3d
Comment 5 WebKit Commit Bot 2010-01-01 11:39:56 PST
Comment on attachment 45731 [details]
move animation test dependent of 3D in 3d directories and move also the expected generated

Rejecting patch 45731 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Fraser', '--force']" exit_code: 1
svn: Path 'LayoutTests/animations/3d/change-transform-in-end-event.html' is not a directory
Failed to svn copy LayoutTests/animations/change-transform-in-end-event.html LayoutTests/animations/3d/change-transform-in-end-event.html. at /Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply line 456.

Full output: http://webkit-commit-queue.appspot.com/results/155915
Comment 6 Mario Bensi 2010-01-01 12:56:06 PST
I don't understand the problem, I use this : 

WebKitTools/Scripts/svn-apply --reviewer 'Simon Fraser' --force layoutTests_animation3D.patch

after checkout again the webkit sources and I haven't problem to apply the patch.

Can you explain me what I can change to fix this problem ?
Comment 7 Eric Seidel (no email) 2010-01-03 16:22:37 PST
I expect these failures were related to bug 28603.
Comment 8 WebKit Commit Bot 2010-01-03 17:48:27 PST
Comment on attachment 45710 [details]
create 3d directory and move tests dependent of 3d in this directory.

Rejecting patch 45710 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11857 test cases.
animations/3d/change-transform-in-end-event.html -> new (results generated in /Users/eseidel/Projects/CommitQueue/LayoutTests/platform/mac/animations/3d)

Exiting early after 1 failures. 109 tests run.
13.52s total testing time

108 test cases (99%) succeeded
1 test case (<1%) was new
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/162136
Comment 9 Eric Seidel (no email) 2010-01-03 17:51:09 PST
change-transform-in-end-event.html is simply missing -expected.txt results.  That' why the first patch is failing to commit properly.
Comment 10 WebKit Commit Bot 2010-01-03 17:56:03 PST
Comment on attachment 45731 [details]
move animation test dependent of 3D in 3d directories and move also the expected generated

Clearing flags on attachment: 45731

Committed r52694: <http://trac.webkit.org/changeset/52694>
Comment 11 Eric Seidel (no email) 2010-01-06 09:53:51 PST
Looks like this was landed.  Closing.