Bug 33066 - [V8] Custom callbacks aren't being declared as such
Summary: [V8] Custom callbacks aren't being declared as such
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
Depends on:
Blocks: 32630
  Show dependency treegraph
Reported: 2009-12-30 16:00 PST by Nate Chapin
Modified: 2010-03-17 10:15 PDT (History)
1 user (show)

See Also:

Remove unused custom callbacks (15.25 KB, patch)
2010-03-16 16:49 PDT, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-12-30 16:00:52 PST
The following callbacks have custom definitions in the v8 bindings, but are not marked as [Custom] or [V8Custom] in their respective .idl.

html/canvas/WebGLByteArray : get()
html/canvas/WebGLFloatArray : get()
html/canvas/WebGLIntArray : get()
html/canvas/WebGLShortArray : get()
html/canvas/WebGLUnsignedByteArray : get()
html/canvas/WebGLUnsignedIntArray : get()
html/canvas/WebGLUnsignedShortArray : get()
page/DOMWindow : clearInterval()
page/DOMWindow : clearTimeout()
xml/XMLHttpRequest : dispatchEvent()
xml/XMLHttpRequestUpload : dispatchEvent()

We should either mark them V8Custom or make them not need to be custom anymore.
Comment 1 Nate Chapin 2010-01-14 10:48:23 PST
This doesn't block deleting V8CustomBinding.h, it's more general cleanup.
Comment 2 Nate Chapin 2010-03-16 16:49:11 PDT
Created attachment 50853 [details]
Remove unused custom callbacks
Comment 3 Kenneth Russell 2010-03-16 17:03:02 PDT
Thanks for the cleanups to the V8WebGL*Array bindings. They look good.
Comment 4 Dimitri Glazkov (Google) 2010-03-16 17:24:14 PDT
Comment on attachment 50853 [details]
Remove unused custom callbacks

Marking as patch.
Comment 5 Dimitri Glazkov (Google) 2010-03-16 17:25:09 PDT
Comment on attachment 50853 [details]
Remove unused custom callbacks

Comment 6 Nate Chapin 2010-03-17 10:15:14 PDT
http://trac.webkit.org/changeset/56114 and build fix in http://trac.webkit.org/changeset/56115.