Bug 33058 - logging.py should be renamed to webkit_logging.py and eventually die
Summary: logging.py should be renamed to webkit_logging.py and eventually die
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-30 10:14 PST by Eric Seidel (no email)
Modified: 2009-12-30 10:37 PST (History)
1 user (show)

See Also:

Attachments
Patch (21.73 KB, patch)
2009-12-30 10:33 PST, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-30 10:14:50 PST 
logging.py should be renamed to webkit_logging.py and eventually die

Turns out that python has a built in logging system.  Who knew?  This python n00b didn't. :)

Anyway, logging.py has the same import name as python's built in logging, so it needs to be renamed if we want to use python's logging.  Eventually our logging module (once renamed to webkit_logging.py) should die.
Comment 1 Eric Seidel (no email) 2009-12-30 10:17:54 PST 
I'm not sure why I created a bug.  Review of this kind of patch isn't very useful.  But I guess I'll post it anyway.
Comment 2 Eric Seidel (no email) 2009-12-30 10:33:12 PST 
Created attachment 45672 [details]
Patch
Comment 3 Adam Barth 2009-12-30 10:34:25 PST 
Comment on attachment 45672 [details]
Patch

Ok.  We have a bunch of these kinds of patches to do.
Comment 4 Eric Seidel (no email) 2009-12-30 10:37:57 PST 
Committed r52667: <http://trac.webkit.org/changeset/52667>