Bug 33052 - [Qt] http/tests/plugins/post-url-file.html failure
Summary: [Qt] http/tests/plugins/post-url-file.html failure
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-30 05:44 PST by Jakub Wieczorek
Modified: 2009-12-30 06:58 PST (History)
2 users (show)

See Also:

proposed patch (3.73 KB, patch)
2009-12-30 05:55 PST, Jakub Wieczorek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-12-30 05:44:31 PST
The test fails because of the FIXME in PluginView::handlePostReadFile():
// FIXME - read the file data into buffer
Comment 1 Jakub Wieczorek 2009-12-30 05:55:09 PST
Created attachment 45660 [details]
proposed patch

Depends on https://bugs.webkit.org/show_bug.cgi?id=33051.
Comment 2 WebKit Review Bot 2009-12-30 05:56:51 PST
style-queue ran check-webkit-style on attachment 45660 [details] without any errors.
Comment 3 Simon Hausmann 2009-12-30 06:50:29 PST
Comment on attachment 45660 [details]
proposed patch

r=me, nice!

Another option would be to rewrite this code to use QFile or even share an implementation across ports if possible...
Comment 4 WebKit Commit Bot 2009-12-30 06:58:39 PST
Comment on attachment 45660 [details]
proposed patch

Clearing flags on attachment: 45660

Committed r52660: <http://trac.webkit.org/changeset/52660>
Comment 5 WebKit Commit Bot 2009-12-30 06:58:45 PST
All reviewed patches have been landed.  Closing bug.