RESOLVED FIXED 33048
[V8] Auto-generate and split DerivedSourcesAllInOne.cpp 
https://bugs.webkit.org/show_bug.cgi?id=33048
Summary [V8] Auto-generate and split DerivedSourcesAllInOne.cpp
Yaar Schnitman
Reported 2009-12-30 03:36:51 PST
DerivedSourcesAllInOne.cpp is maintained manually, which is cumbersome and causes frequent chromium breakage. A new WebCore.gyp action is introduced to automatically generate this file. Chromium issue: http://code.google.com/p/chromium/issues/detail?id=16439
Attachments
Patch 1 (28.62 KB, patch)
2009-12-30 03:43 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Patch (30.56 KB, patch)
2010-02-17 17:11 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Patch (33.34 KB, patch)
2010-02-25 18:32 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Patch (33.34 KB, patch)
2010-02-25 18:36 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Patch (33.69 KB, patch)
2010-02-25 19:14 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Patch (33.49 KB, patch)
2010-02-26 13:20 PST, Yaar Schnitman 		dglazkov: review+
DetailsFormatted DiffDiff
Delete the old DerivedSourcesAllInOne.cpp (19.21 KB, patch)
2010-03-11 16:31 PST, Nate Chapin 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2009-12-30 03:43:48 PST
Created attachment 45651 [details] Patch 1 This patch does the work, but depends on a necessary fix to gyp.
Yaar Schnitman
Comment 2 2009-12-30 03:53:22 PST
Opened a gyp issue: http://code.google.com/p/gyp/issues/detail?id=134
Dimitri Glazkov (Google)
Comment 3 2009-12-30 12:41:13 PST
This looks awesome. I am no gyp wizard, but I have lots of ideas :) 1) I wonder if it's possible to only invoke this action when a certain condition is true? We only need this conglomeration when doing whole-program-optimization Release builds and that's an exceptional configuration, rather than the standard one. 2) It would super-great to build this as a generic conglomerator that work on any directory, like WebCore/svg and such. Is it possible?
Dimitri Glazkov (Google)
Comment 4 2010-02-17 07:55:46 PST
*** Bug 32128 has been marked as a duplicate of this bug. ***
Jeremy Orlow
Comment 5 2010-02-17 08:02:21 PST
Yaar, any eta on getting this in?
Yaar Schnitman
Comment 6 2010-02-17 17:11:20 PST
Created attachment 48951 [details] Patch
Yaar Schnitman
Comment 7 2010-02-25 18:32:57 PST
Created attachment 49557 [details] Patch
Yaar Schnitman
Comment 8 2010-02-25 18:35:37 PST
The file is auto-generated and split into 8 pieces, to reduce compilation units size and allow parallel compilation.
Yaar Schnitman
Comment 9 2010-02-25 18:36:43 PST
Created attachment 49558 [details] Patch
Yaar Schnitman
Comment 10 2010-02-25 18:37:29 PST
Comment on attachment 49558 [details] Patch Gyp changes were landed, and this is ready to go (pending review of course).
WebKit Review Bot
Comment 11 2010-02-25 19:02:50 PST
Attachment 49558 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/314039
Yaar Schnitman
Comment 12 2010-02-25 19:14:30 PST
Created attachment 49560 [details] Patch
Yaar Schnitman
Comment 13 2010-02-25 19:15:25 PST
Comment on attachment 49560 [details] Patch Had to increment gyp's version on the webkit port as well.
WebKit Review Bot
Comment 14 2010-02-25 19:20:42 PST
Attachment 49560 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/313151
Yaar Schnitman
Comment 15 2010-02-26 13:20:12 PST
Created attachment 49631 [details] Patch
Dimitri Glazkov (Google)
Comment 16 2010-02-26 13:23:21 PST
Comment on attachment 49631 [details] Patch Ok. Please watch the canaries. They are dead at the moment.
Nate Chapin
Comment 17 2010-03-11 16:31:59 PST
Created attachment 50558 [details] Delete the old DerivedSourcesAllInOne.cpp
Dimitri Glazkov (Google)
Comment 18 2010-03-11 16:34:32 PST
Comment on attachment 50558 [details] Delete the old DerivedSourcesAllInOne.cpp ok.
Nate Chapin
Comment 19 2010-03-16 16:02:14 PDT
http://trac.webkit.org/changeset/56063
Note You need to log in before you can comment on or make changes to this bug.