Following up on performance concerns raised by Adam and Eric on IRC about the unit test included in the patch for bug #32896. Currently the test method CredentialsTest.test_read_credentials_with_SVN calls SVNTestRepository.setup and SVNTestRepository.tear_down. But these calls are expensive as they perform system calls to create an actual SVN repository and perform some test commits. Instead, it is sufficient to create a temporary directory that does not contain a Git repository.
Created attachment 45638 [details] Patch
Comment on attachment 45638 [details] Patch Why are we keeping around the disabled path?
style-queue ran check-webkit-style on attachment 45638 [details] without any errors.
Comment on attachment 45638 [details] Patch On second thought, we don't need the optional parameter shouldMakeActualSVNRepo and related code as it does add much if any value. Original thought was to make the unit test match the actual environment as close as possible. But it is sufficient to just create a temporary directory (one in which we know does not contain a not Git repo).
Created attachment 45639 [details] Patch Removed unnecessary code that made use of modules.scm_unittest.SVNTestRepository. Also, renamed method test_read_credentials_with_SVN to test_read_credentials_without_Git_repo to better reflect what it is testing.
Comment on attachment 45639 [details] Patch LGTM.
Comment on attachment 45639 [details] Patch test_read_credentials_without_Git_repo capitalization is a bit strange. I would have just called it "git"
(In reply to comment #7) > (From update of attachment 45639 [details]) > test_read_credentials_without_Git_repo > capitalization is a bit strange. I would have just called it "git" I'll fix this before I land.
Committed in <http://trac.webkit.org/changeset/52644>.