Bug 33036 – [bzt] post-diff requires reading to the end

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Barth]

If you don't read to the end of the confirm screen, you get this error:

Traceback (most recent call last):
  File "./WebKitTools/Scripts/bugzilla-tool", line 108, in <module>
    BugzillaTool().main()
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 283, in main
    return command.check_arguments_and_execute(options, args, self)
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 111, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 66, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/stepsequence.py", line 65, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/stepsequence.py", line 59, in _run
    step(tool, options).run(state)
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 234, in run
    self._tool.user.page(diff)
  File "/Users/abarth/svn/kr/src/third_party/WebKit/WebKitTools/Scripts/modules/user.py", line 43, in page
    child_process.communicate(input=message)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py", line 660, in communicate
    self.stdin.write(input)
IOError: [Errno 32] Broken pipe

[Adam Barth]

Created attachment 45628 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45628 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45628 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 45628 [details]
Patch

Clearing flags on attachment: 45628

Committed r52639: <http://trac.webkit.org/changeset/52639>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.