WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33031
[V8] Generate configuring of all indexers.
https://bugs.webkit.org/show_bug.cgi?id=33031
Summary
[V8] Generate configuring of all indexers.
Dimitri Glazkov (Google)
Reported
2009-12-29 15:45:42 PST
It's a bit ugly. The biggest issue is that apparently V8 API completely decouples numeric and non-numeric property lookup, which forces us to have extra indexers. The indexers simply convert index value to string and pass it along to named property handling machinery. It's sad. I'll ask V8 folks what's up with that. Otherwise, the story is very similar to
bug 32996
Attachments
Generate configuring of all indexers, v1.
(13.28 KB, patch)
2009-12-29 15:50 PST
,
Dimitri Glazkov (Google)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-12-29 15:50:12 PST
Created
attachment 45624
[details]
Generate configuring of all indexers, v1.
Adam Barth
Comment 2
2009-12-29 18:51:53 PST
Comment on
attachment 45624
[details]
Generate configuring of all indexers, v1. This patch feels like deja vu. I didn't quite follow all the machinations here, but the net result looks good. Hopefully our tests are strong enough to catch screw ups.
Dimitri Glazkov (Google)
Comment 3
2009-12-30 08:55:45 PST
Landed as
http://trac.webkit.org/changeset/52663
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug