Bug 33031 - [V8] Generate configuring of all indexers.
: [V8] Generate configuring of all indexers.
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: Other All
: P2 Normal
Assigned To:
:
:
: 32996
: 32569
  Show dependency treegraph
 
Reported: 2009-12-29 15:45 PST by
Modified: 2009-12-30 08:55 PST (History)


Attachments
Generate configuring of all indexers, v1. (13.28 KB, patch)
2009-12-29 15:50 PST, Dimitri Glazkov (Google)
abarth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-29 15:45:42 PST
It's a bit ugly. The biggest issue is that apparently V8 API completely decouples numeric and non-numeric property lookup, which forces us to have extra indexers. The indexers simply convert index value to string and pass it along to named property handling machinery. It's sad. I'll ask V8 folks what's up with that.

Otherwise, the story is very similar to bug 32996
------- Comment #1 From 2009-12-29 15:50:12 PST -------
Created an attachment (id=45624) [details]
Generate configuring of all indexers, v1.
------- Comment #2 From 2009-12-29 18:51:53 PST -------
(From update of attachment 45624 [details])
This patch feels like deja vu.  I didn't quite follow all the machinations here, but the net result looks good.  Hopefully our tests are strong enough to catch screw ups.
------- Comment #3 From 2009-12-30 08:55:45 PST -------
Landed as http://trac.webkit.org/changeset/52663.