WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33030
Add a test for window.top and isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=33030
Summary
Add a test for window.top and isolated worlds
Adam Barth
Reported
2009-12-29 14:54:13 PST
Add a test for window.top and isolated worlds
Attachments
Patch
(1.79 KB, patch)
2009-12-29 14:56 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2009-12-29 14:56:46 PST
Created
attachment 45623
[details]
Patch
WebKit Review Bot
Comment 2
2009-12-29 14:59:59 PST
style-queue ran check-webkit-style on
attachment 45623
[details]
without any errors.
Sam Weinig
Comment 3
2009-12-29 15:30:56 PST
Comment on
attachment 45623
[details]
Patch Looks fine, though I wouldn't mind the expected file having a little bit of explanatory text for future me to read.
Dimitri Glazkov (Google)
Comment 4
2009-12-29 15:34:21 PST
And future me too!
Adam Barth
Comment 5
2009-12-29 16:36:36 PST
Comment on
attachment 45623
[details]
Patch Ok. There are a bunch of tests in this style in this directory. We should update them all with explanations.
WebKit Commit Bot
Comment 6
2009-12-29 16:48:24 PST
Comment on
attachment 45623
[details]
Patch Clearing flags on attachment: 45623 Committed
r52638
: <
http://trac.webkit.org/changeset/52638
>
WebKit Commit Bot
Comment 7
2009-12-29 16:48:32 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug