Bug 33024 – Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Nothing happens when trying to navigate to, say, a linked stylesheet (by clicking the "href" or "src" attribute value that looks like "main.css" or "/css/main.css") from the Elements Outline Tree.

This is an upstream of the Chromium http://code.google.com/p/chromium/issues/detail?id=24892 issue.

[Alexander Pavlov (apavlov)]

Created attachment 45615 [details]
[PATCH] Suggested solution

[Alexander Pavlov (apavlov)]

Created attachment 46270 [details]
patch

[Pavel Feldman]

Comment on attachment 46270 [details]
patch

Test for this would be great.

[WebKit Commit Bot]

Comment on attachment 46270 [details]
patch

Rejecting patch 46270 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11905 test cases.
inspector/cookie-resource-match.html -> failed

Exiting early after 1 failures. 8706 tests run.
149.54s total testing time

8705 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/177793

[Alexander Pavlov (apavlov)]

Created attachment 46278 [details]
patch (fixed + layout test)

[WebKit Commit Bot]

Comment on attachment 46278 [details]
patch (fixed + layout test)

Clearing flags on attachment: 46278

Committed r53100: <http://trac.webkit.org/changeset/53100>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Looks like this test needs to be skipped on Qt:
http://build.webkit.org/results/Qt%20Linux%20Release/r53100%20(5847)/inspector/elements-panel-rewrite-href-diffs.txt

--- layout-test-results/inspector/elements-panel-rewrite-href-expected.txt	2010-01-11 14:40:14.000000000 -0800
+++ layout-test-results/inspector/elements-panel-rewrite-href-actual.txt	2010-01-11 14:40:14.000000000 -0800
@@ -1,7 +1,5 @@
+CONSOLE MESSAGE: line 28: TypeError: Result of expression 'layoutTestController.evaluateInWebInspector' [undefined] is not a function.
+FAIL: Timed out waiting for notifyDone to be called
 Tests that src and href element targets are rewritten properly.
 
-[,bogusSheet1.css]
-[LayoutTests,inspector,bogusSheet2.css]
-[LayoutTests,inspector,inspector-test.js]
-[LayoutTests,inspector,elements-tests.js]

[Eric Seidel (no email)]

bug 33096 is the Qt bug about adding this functionality.

[Eric Seidel (no email)]

Committed r53102: <http://trac.webkit.org/changeset/53102>