Bug 33024 - Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
Summary: Web Inspector: External resource relative URLs cannot be navigated to from th...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-29 10:51 PST by Alexander Pavlov (apavlov)
Modified: 2010-01-11 14:53 PST (History)
9 users (show)

See Also:

[PATCH] Suggested solution (3.40 KB, patch)
2009-12-29 10:58 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
patch (3.77 KB, patch)
2010-01-11 04:27 PST, Alexander Pavlov (apavlov)
pfeldman: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (fixed + layout test) (7.55 KB, patch)
2010-01-11 08:40 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2009-12-29 10:51:23 PST
Nothing happens when trying to navigate to, say, a linked stylesheet (by clicking the "href" or "src" attribute value that looks like "main.css" or "/css/main.css") from the Elements Outline Tree.

This is an upstream of the Chromium http://code.google.com/p/chromium/issues/detail?id=24892 issue.
Comment 1 Alexander Pavlov (apavlov) 2009-12-29 10:58:31 PST
Created attachment 45615 [details]
[PATCH] Suggested solution
Comment 2 Alexander Pavlov (apavlov) 2010-01-11 04:27:38 PST
Created attachment 46270 [details]
Comment 3 Pavel Feldman 2010-01-11 05:43:04 PST
Comment on attachment 46270 [details]

Test for this would be great.
Comment 4 WebKit Commit Bot 2010-01-11 05:57:41 PST
Comment on attachment 46270 [details]

Rejecting patch 46270 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11905 test cases.
inspector/cookie-resource-match.html -> failed

Exiting early after 1 failures. 8706 tests run.
149.54s total testing time

8705 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/177793
Comment 5 Alexander Pavlov (apavlov) 2010-01-11 08:40:26 PST
Created attachment 46278 [details]
patch (fixed + layout test)
Comment 6 WebKit Commit Bot 2010-01-11 14:33:16 PST
Comment on attachment 46278 [details]
patch (fixed + layout test)

Clearing flags on attachment: 46278

Committed r53100: <http://trac.webkit.org/changeset/53100>
Comment 7 WebKit Commit Bot 2010-01-11 14:33:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-01-11 14:46:30 PST
Looks like this test needs to be skipped on Qt:

--- layout-test-results/inspector/elements-panel-rewrite-href-expected.txt	2010-01-11 14:40:14.000000000 -0800
+++ layout-test-results/inspector/elements-panel-rewrite-href-actual.txt	2010-01-11 14:40:14.000000000 -0800
@@ -1,7 +1,5 @@
+CONSOLE MESSAGE: line 28: TypeError: Result of expression 'layoutTestController.evaluateInWebInspector' [undefined] is not a function.
+FAIL: Timed out waiting for notifyDone to be called
 Tests that src and href element targets are rewritten properly.
Comment 9 Eric Seidel (no email) 2010-01-11 14:48:21 PST
bug 33096 is the Qt bug about adding this functionality.
Comment 10 Eric Seidel (no email) 2010-01-11 14:53:09 PST
Committed r53102: <http://trac.webkit.org/changeset/53102>