Bug 33023 - webkit-patch post and post-commits commands should be combined into one
Summary: webkit-patch post and post-commits commands should be combined into one
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-29 10:50 PST by Eric Seidel (no email)
Modified: 2010-01-19 16:59 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-29 10:50:16 PST
[bzt] bugzilla-tool post-diff and post-commits commands should be combined into one

Then we could name the resulting command whatever we'd like.  Maciej was suggesting "post-patch" in a private email thread involving Adam Barth and myself.

If someone has suggestions for what the command line interface should look like, I'm all ears.

Right now:
post-diff [options] [BUGID]   Attach the current working directory diff to a bug as a patch file
post-commits [options] COMMITISH   Attach a range of local commits to bugs as patch files

I suspect we could pretty easily detect the difference between a commitish and a BUGID.  It's also slightly strange that post-commits takes a bug-id option flag:
  -b BUG_ID, --bug-id=BUG_ID   Specify bug id if no URL is provided in the commit log.
Comment 1 Adam Barth 2009-12-29 11:48:15 PST
How important is it to support the post-commits use case?  I've never used this.
Comment 2 Eric Seidel (no email) 2009-12-29 11:55:52 PST
post-commits (or some variant there of) is very useful if you happen to commit locally to git branches.  Especially with some sort of auto-squashing support like bug 32730.  However, I don't think our overall patch process for git is very clean.