WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
33023
webkit-patch post and post-commits commands should be combined into one
https://bugs.webkit.org/show_bug.cgi?id=33023
Summary
webkit-patch post and post-commits commands should be combined into one
Eric Seidel (no email)
Reported
2009-12-29 10:50:16 PST
[bzt] bugzilla-tool post-diff and post-commits commands should be combined into one Then we could name the resulting command whatever we'd like. Maciej was suggesting "post-patch" in a private email thread involving Adam Barth and myself. If someone has suggestions for what the command line interface should look like, I'm all ears. Right now: post-diff [options] [BUGID] Attach the current working directory diff to a bug as a patch file post-commits [options] COMMITISH Attach a range of local commits to bugs as patch files I suspect we could pretty easily detect the difference between a commitish and a BUGID. It's also slightly strange that post-commits takes a bug-id option flag: -b BUG_ID, --bug-id=BUG_ID Specify bug id if no URL is provided in the commit log.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2009-12-29 11:48:15 PST
How important is it to support the post-commits use case? I've never used this.
Eric Seidel (no email)
Comment 2
2009-12-29 11:55:52 PST
post-commits (or some variant there of) is very useful if you happen to commit locally to git branches. Especially with some sort of auto-squashing support like
bug 32730
. However, I don't think our overall patch process for git is very clean.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug