Bug 33020 - Allow call sites to determine if ASSERT_* and LOG_* macros are operational
Summary: Allow call sites to determine if ASSERT_* and LOG_* macros are operational
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-29 07:39 PST by Laszlo Gombos
Modified: 2010-01-07 22:54 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (5.68 KB, patch)
2009-12-29 07:43 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-12-29 07:39:01 PST 
These build time macros (e.g. like ASSERT_MSG_DISABLED or LOG_DISABLED) could be used to guard debugging/tracing helper functions - e.g. in situations like this one: http://trac.webkit.org/changeset/52621#file1.
Comment 1 Laszlo Gombos 2009-12-29 07:43:15 PST 
Created attachment 45602 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-29 07:48:47 PST 
style-queue ran check-webkit-style on attachment 45602 [details] without any errors.
Comment 3 Maciej Stachowiak 2010-01-07 02:31:18 PST 
Comment on attachment 45602 [details]
proposed patch

r=me
Comment 4 WebKit Commit Bot 2010-01-07 22:54:33 PST 
Comment on attachment 45602 [details]
proposed patch

Clearing flags on attachment: 45602

Committed r52973: <http://trac.webkit.org/changeset/52973>
Comment 5 WebKit Commit Bot 2010-01-07 22:54:39 PST 
All reviewed patches have been landed.  Closing bug.