WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33020
Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020
Summary
Allow call sites to determine if ASSERT_* and LOG_* macros are operational
Laszlo Gombos
Reported
2009-12-29 07:39:01 PST
These build time macros (e.g. like ASSERT_MSG_DISABLED or LOG_DISABLED) could be used to guard debugging/tracing helper functions - e.g. in situations like this one:
http://trac.webkit.org/changeset/52621#file1
.
Attachments
proposed patch
(5.68 KB, patch)
2009-12-29 07:43 PST
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2009-12-29 07:43:15 PST
Created
attachment 45602
[details]
proposed patch
WebKit Review Bot
Comment 2
2009-12-29 07:48:47 PST
style-queue ran check-webkit-style on
attachment 45602
[details]
without any errors.
Maciej Stachowiak
Comment 3
2010-01-07 02:31:18 PST
Comment on
attachment 45602
[details]
proposed patch r=me
WebKit Commit Bot
Comment 4
2010-01-07 22:54:33 PST
Comment on
attachment 45602
[details]
proposed patch Clearing flags on attachment: 45602 Committed
r52973
: <
http://trac.webkit.org/changeset/52973
>
WebKit Commit Bot
Comment 5
2010-01-07 22:54:39 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug