Bug 33003 - Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
Summary: Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-28 18:43 PST by Laszlo Gombos
Modified: 2009-12-29 05:22 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (6.43 KB, patch)
2009-12-28 18:47 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-12-28 18:43:23 PST
Warnings found in debug builds only.

This patch is similar to the previously committed r42002 and r50675.

List of warnings:
WebCore/editing/CompositeEditCommand.cpp: In member function ‘bool WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()’:
WebCore/editing/CompositeEditCommand.cpp:1093: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/page/animation/ImplicitAnimation.cpp: In member function ‘bool WebCore::ImplicitAnimation::sendTransitionEvent(const WebCore::AtomicString&, double)’:
WebCore/page/animation/ImplicitAnimation.cpp:164: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/page/animation/KeyframeAnimation.cpp: In member function ‘bool WebCore::KeyframeAnimation::sendAnimationEvent(const WebCore::AtomicString&, double)’:
WebCore/page/animation/KeyframeAnimation.cpp:284: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/rendering/RenderSVGContainer.h: In function ‘WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(WebCore::RenderObject*)’:
WebCore/rendering/RenderSVGContainer.h:81: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/rendering/RenderSVGContainer.h: In function ‘const WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(const WebCore::RenderObject*)’:
WebCore/rendering/RenderSVGContainer.h:88: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/rendering/style/RenderStyle.cpp: In member function ‘void WebCore::RenderStyle::setTextShadow(WebCore::ShadowData*, bool)’:
WebCore/rendering/style/RenderStyle.cpp:705: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/svg/graphics/SVGPaintServerGradient.cpp: In member function ‘virtual bool WebCore::SVGPaintServerGradient::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’:
WebCore/svg/graphics/SVGPaintServerGradient.cpp:196: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/svg/graphics/SVGPaintServerPattern.cpp: In member function ‘virtual bool WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’:
WebCore/svg/graphics/SVGPaintServerPattern.cpp:106: warning: suggest parentheses around ‘&&’ within ‘||’
Comment 1 Laszlo Gombos 2009-12-28 18:47:46 PST
Created attachment 45583 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-28 18:53:21 PST
style-queue ran check-webkit-style on attachment 45583 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-28 23:58:42 PST
Comment on attachment 45583 [details]
proposed patch

This looks right to me.
Comment 4 WebKit Commit Bot 2009-12-29 05:22:06 PST
Comment on attachment 45583 [details]
proposed patch

Clearing flags on attachment: 45583

Committed r52618: <http://trac.webkit.org/changeset/52618>
Comment 5 WebKit Commit Bot 2009-12-29 05:22:11 PST
All reviewed patches have been landed.  Closing bug.