RESOLVED FIXED Bug 32975
[check-webkit-style] does understand ResourceHandleWin.h 
https://bugs.webkit.org/show_bug.cgi?id=32975
Summary [check-webkit-style] does understand ResourceHandleWin.h
Adam Barth
Reported 2009-12-27 18:10:10 PST
Comment #4 From Patrick R. Gansterer 2009-12-27 10:48:12 PST (-) [reply] (In reply to comment #2) > WebCore/platform/network/win/ResourceHandleWin.cpp:38: Found header this file > implements after other header. Should be: config.h, primary header, blank line, > and then alphabetically sorted. [build/include_order] [4] The primary header header is ResourceHandle.h. ResourceHandleWin.h is only an ugly helperfile. https://bugs.webkit.org/show_bug.cgi?id=32963#c4
Attachments
Patch (2.71 KB, patch)
2010-01-17 16:15 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.73 KB, patch)
2010-01-18 01:11 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-17 16:15:07 PST
Created attachment 46768 [details] Patch
Shinichiro Hamaji
Comment 2 2010-01-17 17:29:13 PST
Comment on attachment 46768 [details] Patch > + # Thus far, we've only seen one example of these, but if we start > + # to see more, please consider abstracting this check somehow. Using FIXME would be better?
Adam Barth
Comment 3 2010-01-18 01:11:15 PST
Created attachment 46798 [details] Patch for landing
Adam Barth
Comment 4 2010-01-18 02:13:10 PST
Comment on attachment 46798 [details] Patch for landing Clearing flags on attachment: 46798 Committed r53398: <http://trac.webkit.org/changeset/53398>
Adam Barth
Comment 5 2010-01-18 02:13:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.