WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32973
check-webkit-style: Make a single module that runs the style package unit tests
https://bugs.webkit.org/show_bug.cgi?id=32973
Summary
check-webkit-style: Make a single module that runs the style package unit tests
Chris Jerdonek
Reported
2009-12-27 16:00:29 PST
The file can be located at modules/style/unittest.py. run-webkit-unittests should then be modified to import only this file. This will make run-webkit-unittests easier to maintain as the style "package" changes.
Attachments
Proposed patch
(3.62 KB, patch)
2010-01-07 01:26 PST
,
Chris Jerdonek
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Jerdonek
Comment 1
2009-12-28 17:49:37 PST
Removed brackets from bug title.
Chris Jerdonek
Comment 2
2010-01-07 01:25:13 PST
This is so that test-webkitpy doesn't have to know the structure of the style package, and vice versa -- the style package doesn't have to worry about updating outside files like test-webkitpy.
Chris Jerdonek
Comment 3
2010-01-07 01:26:38 PST
Created
attachment 46031
[details]
Proposed patch
WebKit Review Bot
Comment 4
2010-01-07 01:29:14 PST
style-queue ran check-webkit-style on
attachment 46031
[details]
without any errors.
Adam Barth
Comment 5
2010-01-07 01:39:44 PST
Comment on
attachment 46031
[details]
Proposed patch Thanks for teach me Python. We should do the same with steps and commands.
Chris Jerdonek
Comment 6
2010-01-07 01:56:36 PST
(In reply to
comment #5
)
> (From update of
attachment 46031
[details]
) > Thanks for teach me Python. We should do the same with steps and commands.
Thanks, Adam!
WebKit Commit Bot
Comment 7
2010-01-07 03:50:56 PST
Comment on
attachment 46031
[details]
Proposed patch Clearing flags on attachment: 46031 Committed
r52916
: <
http://trac.webkit.org/changeset/52916
>
WebKit Commit Bot
Comment 8
2010-01-07 03:51:03 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug