Bug 32956 - wx port needs to expose settings
Summary: wx port needs to expose settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-26 20:49 PST by Kevin Watters
Modified: 2009-12-30 11:29 PST (History)
3 users (show)

See Also:

Attachments
expose settings in a wxWebSettings object (19.81 KB, patch)
2009-12-26 20:49 PST, Kevin Watters 		kevino: review+
kevino: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2009-12-26 20:49:03 PST 
Created attachment 45517 [details]
expose settings in a wxWebSettings object

The wx port could expose some basic settings in its API.
Comment 1 WebKit Review Bot 2009-12-26 20:49:49 PST 
style-queue ran check-webkit-style on attachment 45517 [details] without any errors.
Comment 2 Eric Seidel (no email) 2009-12-28 22:27:18 PST 
I'm confused by this code being Copyright Kevin Olliver and yet Kevin Olliver is reviewing the patch?  I'm also confused by it being marked cq- (which is totally fine, just surprising given that Watters is not a committer).
Comment 3 Kevin Ollivier 2009-12-30 11:29:39 PST 
Landed in r52668, thanks!