Bug 32939 - [WINCE] Buildfix for jsc
Summary: [WINCE] Buildfix for jsc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33056
  Show dependency treegraph
 
Reported: 2009-12-25 13:24 PST by Patrick R. Gansterer
Modified: 2010-01-05 14:30 PST (History)
3 users (show)

See Also:


Attachments
Buildfix for jsc.cpp (4.53 KB, patch)
2009-12-25 13:24 PST, Patrick R. Gansterer
eric: review-
commit-queue: commit-queue-
Details | Formatted Diff | Diff
WinMain function for WinCE (3.35 KB, patch)
2009-12-25 13:30 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Buildfix for MainThreadWin.cpp (1.43 KB, patch)
2009-12-25 16:57 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Some buildfixes for WebCore/platform/wince/ (2.01 KB, patch)
2009-12-25 18:27 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Buildfix for RenderThemeWince.cpp (4.68 KB, patch)
2009-12-26 06:11 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Buildfix for TextBreakIteratorWince.cpp (1.05 KB, patch)
2009-12-26 06:41 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Buildfix for jsc.cpp (4.72 KB, patch)
2009-12-31 00:30 PST, Patrick R. Gansterer
eric: review+
paroga: commit-queue-
Details | Formatted Diff | Diff
Buildfix for jsc.cpp (4.71 KB, patch)
2010-01-05 13:46 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2009-12-25 13:24:15 PST
Created attachment 45497 [details]
Buildfix for jsc.cpp

jsc.cpp can't be compiled because functionQuit doesn't return a value.
I also fixed some style errors
Comment 1 WebKit Review Bot 2009-12-25 13:26:14 PST
style-queue ran check-webkit-style on attachment 45497 [details] without any errors.
Comment 2 Patrick R. Gansterer 2009-12-25 13:30:01 PST
Created attachment 45498 [details]
WinMain function for WinCE

WinCE doesn't support a main function, only a WinMain. This is a simple wrapper to call the usual main, which only needs to be linked additionaly.
Maybe there is a better place for this file instead of os-win32?
This file can be reused by other executables too, insted of only patching jsc.cpp
Comment 3 WebKit Review Bot 2009-12-25 13:31:35 PST
Attachment 45498 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/os-win32/WinMain.cpp:22:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1
Comment 4 Patrick R. Gansterer 2009-12-25 16:57:13 PST
Created attachment 45502 [details]
Buildfix for MainThreadWin.cpp

HWND_MESSAGE isn't supported on WinCE. See http://social.msdn.microsoft.com/forums/en-US/vssmartdevicesnative/thread/dadf671b-faa3-45f7-9b67-42c3b5959373
Comment 5 WebKit Review Bot 2009-12-25 16:59:08 PST
style-queue ran check-webkit-style on attachment 45502 [details] without any errors.
Comment 6 Patrick R. Gansterer 2009-12-25 18:27:43 PST
Created attachment 45504 [details]
Some buildfixes for WebCore/platform/wince/

This are only the first (simple) fixes. Many of the other files don't compile too :-(
Comment 7 WebKit Review Bot 2009-12-25 18:30:11 PST
style-queue ran check-webkit-style on attachment 45504 [details] without any errors.
Comment 8 Adam Barth 2009-12-25 20:02:17 PST
Comment on attachment 45498 [details]
WinMain function for WinCE

ok
Comment 9 Adam Barth 2009-12-25 20:03:43 PST
Comment on attachment 45504 [details]
Some buildfixes for WebCore/platform/wince/

ok...  I like the previous patch's way of handling this slightly better.
Comment 10 Patrick R. Gansterer 2009-12-26 06:11:37 PST
Created attachment 45508 [details]
Buildfix for RenderThemeWince.cpp
Comment 11 WebKit Review Bot 2009-12-26 06:12:09 PST
style-queue ran check-webkit-style on attachment 45508 [details] without any errors.
Comment 12 Patrick R. Gansterer 2009-12-26 06:41:19 PST
Created attachment 45509 [details]
Buildfix for TextBreakIteratorWince.cpp
Comment 13 WebKit Review Bot 2009-12-26 06:42:39 PST
style-queue ran check-webkit-style on attachment 45509 [details] without any errors.
Comment 14 WebKit Commit Bot 2009-12-27 00:11:20 PST
Comment on attachment 45497 [details]
Buildfix for jsc.cpp

Rejecting patch 45497 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit']" exit_code: 1
Last 500 characters of output:
uild/Release/testapi.build/Script-14D857B50A469C100032146C.sh


=== BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release ===

Checking Dependencies...
** BUILD FAILED **

The following build commands failed:
jsc:
	Distributed-CompileC /Users/eseidel/Projects/CommitQueueSVN/WebKitBuild/JavaScriptCore.build/Release/jsc.build/Objects-normal/i386/jsc.o /Users/eseidel/Projects/CommitQueueSVN/JavaScriptCore/jsc.cpp normal i386 c++ com.apple.compilers.gcc.4_2
(1 failure)


Full output: http://webkit-commit-queue.appspot.com/results/149141
Comment 15 WebKit Commit Bot 2009-12-27 00:24:23 PST
Comment on attachment 45498 [details]
WinMain function for WinCE

Clearing flags on attachment: 45498

Committed r52570: <http://trac.webkit.org/changeset/52570>
Comment 16 Eric Seidel (no email) 2009-12-27 00:26:06 PST
Comment on attachment 45508 [details]
Buildfix for RenderThemeWince.cpp

LGTM.
Comment 17 Eric Seidel (no email) 2009-12-27 00:26:30 PST
Comment on attachment 45509 [details]
Buildfix for TextBreakIteratorWince.cpp

LGTM.
Comment 18 Eric Seidel (no email) 2009-12-27 00:29:27 PST
Each of these fixes really should have had its own bug.  Or at least the ChangeLogs should have all referenced bugs, even if they were all the same bug.
Comment 19 WebKit Commit Bot 2009-12-27 00:32:11 PST
Comment on attachment 45502 [details]
Buildfix for MainThreadWin.cpp

Clearing flags on attachment: 45502

Committed r52571: <http://trac.webkit.org/changeset/52571>
Comment 20 Patrick R. Gansterer 2009-12-27 00:35:29 PST
(In reply to comment #14)
> (From update of attachment 45497 [details])
> Rejecting patch 45497 from commit-queue.
Do you have more infos about the error?

(In reply to comment #18)
> Each of these fixes really should have had its own bug.  Or at least the
> ChangeLogs should have all referenced bugs, even if they were all the same bug.
I started only with getting jsc running, but then i found more and more
errors...
I also have many too for posting it here. Should i realy open a bug for every
single file or should i pack them into one patch?

Sidenote: #32169 has a pending review, but no comments on it.
Comment 21 WebKit Commit Bot 2009-12-27 00:40:07 PST
Comment on attachment 45504 [details]
Some buildfixes for WebCore/platform/wince/

Clearing flags on attachment: 45504

Committed r52572: <http://trac.webkit.org/changeset/52572>
Comment 22 WebKit Commit Bot 2009-12-27 00:47:59 PST
Comment on attachment 45508 [details]
Buildfix for RenderThemeWince.cpp

Clearing flags on attachment: 45508

Committed r52573: <http://trac.webkit.org/changeset/52573>
Comment 23 WebKit Commit Bot 2009-12-27 00:55:53 PST
Comment on attachment 45509 [details]
Buildfix for TextBreakIteratorWince.cpp

Clearing flags on attachment: 45509

Committed r52574: <http://trac.webkit.org/changeset/52574>
Comment 24 Eric Seidel (no email) 2009-12-27 08:31:00 PST
Not every patch needs a new bug, but it's often helpful.  In this case, the only problem is that all the ChangeLogs should have had a bug number in them.  Neither is a big deal.  Thanks again for the patches!
Comment 25 Eric Seidel (no email) 2009-12-28 22:25:48 PST
Comment on attachment 45497 [details]
Buildfix for jsc.cpp

Marking this patch r- since it would break the Mac build (at least according to the commit-queue output).
Comment 26 Patrick R. Gansterer 2009-12-29 08:20:48 PST
(In reply to comment #25)
> (From update of attachment 45497 [details])
> Marking this patch r- since it would break the Mac build (at least according to
> the commit-queue output).
Can you please provide me the errormessage of the compiler. I don't know where the problem might be and don't have a Mac to compile it myself. Does Mac require no statement after an exit????
Comment 27 Eric Seidel (no email) 2009-12-29 09:20:39 PST
The bot already provided the error message in comment 14:
https://bugs.webkit.org/show_bug.cgi?id=32939#c14
Comment 28 Eric Seidel (no email) 2009-12-29 09:21:42 PST
A little searching through the full output linked to from comment 14 found this:

cc1plus: warnings being treated as errors
/Users/eseidel/Projects/CommitQueueSVN/JavaScriptCore/jsc.cpp: In function ‘JSC::JSValue functionQuit(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&)’:
/Users/eseidel/Projects/CommitQueueSVN/JavaScriptCore/jsc.cpp:297: warning: function declared ‘noreturn’ has a ‘return’ statement
distcc[4729] ERROR: compile /Users/eseidel/Projects/CommitQueueSVN/JavaScriptCore/jsc.cpp on localhost failed
Comment 29 Patrick R. Gansterer 2009-12-30 10:26:08 PST
(In reply to comment #27)
> The bot already provided the error message in comment 14:
> https://bugs.webkit.org/show_bug.cgi?id=32939#c14
Ok, i didn't found it between the many setenv, when i looked at it :-(
Do you see a way to improve the output? A HTML-output with anchor tags for every target and a dictionary?

With patch from bug 33056 i got a better error message. So the NO_RETUN must not be used, but I think that it won't compile with GCC afterwards? Can i try this without a mac?
Comment 30 Patrick R. Gansterer 2009-12-31 00:30:06 PST
Created attachment 45704 [details]
Buildfix for jsc.cpp
Comment 31 WebKit Review Bot 2009-12-31 00:31:19 PST
style-queue ran check-webkit-style on attachment 45704 [details] without any errors.
Comment 32 Eric Seidel (no email) 2010-01-05 13:32:24 PST
Comment on attachment 45704 [details]
Buildfix for jsc.cpp

OK.
Comment 33 Patrick R. Gansterer 2010-01-05 13:46:11 PST
Created attachment 45930 [details]
Buildfix for jsc.cpp

The PLATFORM() macro changed to OS() in the meantime
Comment 34 WebKit Review Bot 2010-01-05 13:47:36 PST
style-queue ran check-webkit-style on attachment 45930 [details] without any errors.
Comment 35 Eric Seidel (no email) 2010-01-05 13:58:33 PST
Comment on attachment 45930 [details]
Buildfix for jsc.cpp

OK.

I'm not sure why you moved --help to the end, but looks OK.
Comment 36 Patrick R. Gansterer 2010-01-05 14:03:33 PST
(In reply to comment #35)
> I'm not sure why you moved --help to the end, but looks OK.
There is no sorting and so all cases witch a continue at the end are together.
Comment 37 WebKit Commit Bot 2010-01-05 14:30:25 PST
Comment on attachment 45930 [details]
Buildfix for jsc.cpp

Clearing flags on attachment: 45930

Committed r52824: <http://trac.webkit.org/changeset/52824>
Comment 38 WebKit Commit Bot 2010-01-05 14:30:40 PST
All reviewed patches have been landed.  Closing bug.