Bug 32907 - Cleanup of #define JS_EXPORT
Summary: Cleanup of #define JS_EXPORT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 11:02 PST by Patrick R. Gansterer
Modified: 2009-12-28 08:58 PST (History)
5 users (show)

See Also:

Attachments
Cleanup of #define JS_EXPORT (2.69 KB, patch)
2009-12-23 11:02 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2009-12-23 11:02:05 PST 
Created attachment 45442 [details]
Cleanup of #define JS_EXPORT

Merged the WinCE part into the general Windows part.
Comment 1 WebKit Review Bot 2009-12-23 11:07:17 PST 
style-queue ran check-webkit-style on attachment 45442 [details] without any errors.
Comment 2 Maciej Stachowiak 2009-12-28 02:09:03 PST 
Comment on attachment 45442 [details]
Cleanup of #define JS_EXPORT

r=me but make sure to watch the bots when landing this or otherwise verify that other ports will still build.
Comment 3 Eric Seidel (no email) 2009-12-28 08:39:38 PST 
Comment on attachment 45442 [details]
Cleanup of #define JS_EXPORT

Well, the EWS says that Chromium and Qt still build with this (https://webkit-commit-queue.appspot.com/patch/45442), and the commit-queue will check Leopard Release, so I think this is safe to commit.  I'll roll it out if it breaks stuff.
Comment 4 WebKit Commit Bot 2009-12-28 08:58:39 PST 
Comment on attachment 45442 [details]
Cleanup of #define JS_EXPORT

Clearing flags on attachment: 45442

Committed r52598: <http://trac.webkit.org/changeset/52598>
Comment 5 WebKit Commit Bot 2009-12-28 08:58:44 PST 
All reviewed patches have been landed.  Closing bug.