Bug 32898 - [Qt] Add page zooming support to Qt DumpRenderTree
Summary: [Qt] Add page zooming support to Qt DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32899
  Show dependency treegraph
 
Reported: 2009-12-23 04:11 PST by Kim Grönholm
Modified: 2010-01-06 20:03 PST (History)
5 users (show)

See Also:


Attachments
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list (3.95 KB, patch)
2009-12-23 04:18 PST, Kim Grönholm
no flags Details | Formatted Diff | Diff
Proposed patch v0.2 (4.02 KB, patch)
2010-01-06 12:29 PST, Diego Gonzalez
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Grönholm 2009-12-23 04:11:57 PST
Add zoomPageIn() and zoomPageOut() functions to Qt EventSender. Remove the layout tests depending on these functions from the QtWebKit Skipped list.
Comment 1 Kim Grönholm 2009-12-23 04:18:28 PST
Created attachment 45430 [details]
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list

Added a patch to fix this issue.

One of the tests needed minor refactoring because it failed due to
"layoutTestController.notifyDone();" stopping the execution and
therefore the lines:
PASS successfullyParsed is true

TEST COMPLETE
never got outputted. I mimic some other tests and changed it accordingly
and now it works.
Comment 2 WebKit Review Bot 2009-12-23 04:20:11 PST
style-queue ran check-webkit-style on attachment 45430 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-23 13:18:23 PST
Comment on attachment 45430 [details]
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list

I don't understand the re-ordering in clientXY-in-zoom-and-scroll.html
Comment 4 Eric Seidel (no email) 2010-01-05 13:48:03 PST
Comment on attachment 45430 [details]
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list

I don't understand the change to:
LayoutTests/fast/events/clientXY-in-zoom-and-scroll.html

otherwise this looks fine.  Could you please explain?  Ideally updating the changelog with an explanation?
Comment 5 Diego Gonzalez 2010-01-06 12:29:06 PST
Created attachment 45979 [details]
Proposed patch v0.2

It's a possible solution based on Kim Grönholm patch without any modification in clientXY-in-zoom-and-scroll.html
file.

This patch also enable two skipped tests (fast/events/clientXY-in-zoom-and-scroll.html and
fast/dom/elementFromPoint-relative-to-viewport.html). The test caretRangeFromPoint-in-zoom-and-scroll.html
was rearranged in the Skipped file because it's still failing even with zoomPageIn and zoomPageOut implementation.
Comment 6 Antonio Gomes 2010-01-06 12:32:20 PST
LGTM
Comment 7 Kenneth Rohde Christiansen 2010-01-06 12:35:45 PST
Comment on attachment 45979 [details]
Proposed patch v0.2


> +        Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,

Please make sure his name is written correct. Did you upload the patch with bugzilla-tool?


>  
> +#define ZOOM_STEP           1.2
>  

Why 1.2 and not 1.3? Please add a comment explaining why (required by DRT?)
Comment 8 Antonio Gomes 2010-01-06 20:03:16 PST
r52897