Add zoomPageIn() and zoomPageOut() functions to Qt EventSender. Remove the layout tests depending on these functions from the QtWebKit Skipped list.
Created attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list Added a patch to fix this issue. One of the tests needed minor refactoring because it failed due to "layoutTestController.notifyDone();" stopping the execution and therefore the lines: PASS successfullyParsed is true TEST COMPLETE never got outputted. I mimic some other tests and changed it accordingly and now it works.
style-queue ran check-webkit-style on attachment 45430 [details] without any errors.
Comment on attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list I don't understand the re-ordering in clientXY-in-zoom-and-scroll.html
Comment on attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list I don't understand the change to: LayoutTests/fast/events/clientXY-in-zoom-and-scroll.html otherwise this looks fine. Could you please explain? Ideally updating the changelog with an explanation?
Created attachment 45979 [details] Proposed patch v0.2 It's a possible solution based on Kim Grönholm patch without any modification in clientXY-in-zoom-and-scroll.html file. This patch also enable two skipped tests (fast/events/clientXY-in-zoom-and-scroll.html and fast/dom/elementFromPoint-relative-to-viewport.html). The test caretRangeFromPoint-in-zoom-and-scroll.html was rearranged in the Skipped file because it's still failing even with zoomPageIn and zoomPageOut implementation.
LGTM
Comment on attachment 45979 [details] Proposed patch v0.2 > + Patch by Kim Grönholm <kim.gronholm@nomovok.com>, Please make sure his name is written correct. Did you upload the patch with bugzilla-tool? > > +#define ZOOM_STEP 1.2 > Why 1.2 and not 1.3? Please add a comment explaining why (required by DRT?)
r52897