WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32897
Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=32897
Summary
Web Inspector: [REGRESSION] console's clear command does not work.
Pavel Feldman
Reported
2009-12-23 02:29:15 PST
It turned out that console's clear command should be in InjectedScriptHost, not InspectorBackend binding.
Attachments
[PATCH] Proposed fix
(13.26 KB, patch)
2009-12-23 02:32 PST
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2009-12-23 02:32:50 PST
Created
attachment 45427
[details]
[PATCH] Proposed fix
WebKit Review Bot
Comment 2
2009-12-23 02:33:40 PST
style-queue ran check-webkit-style on
attachment 45427
[details]
without any errors.
Timothy Hatcher
Comment 3
2009-12-23 12:56:12 PST
Comment on
attachment 45427
[details]
[PATCH] Proposed fix
> + requestClearConsoleMessages: function() > + clearConsoleMessages: function()
Having "Console" in these function names is redundant when they are on the ConsoleView object and always referenced in context.
Pavel Feldman
Comment 4
2009-12-24 02:54:13 PST
(In reply to
comment #3
)
> (From update of
attachment 45427
[details]
) > > + requestClearConsoleMessages: function() > > + clearConsoleMessages: function() > > Having "Console" in these function names is redundant when they are on the > ConsoleView object and always referenced in context.
Done.
Pavel Feldman
Comment 5
2009-12-24 03:06:27 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M LayoutTests/ChangeLog M LayoutTests/inspector/console-tests.js M WebCore/ChangeLog M WebCore/inspector/InjectedScriptHost.cpp M WebCore/inspector/InjectedScriptHost.h M WebCore/inspector/InjectedScriptHost.idl M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/InjectedScriptAccess.js M WebCore/inspector/front-end/inspector.js Committed
r52545
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug