Bug 32897 - Web Inspector: [REGRESSION] console's clear command does not work.
Summary: Web Inspector: [REGRESSION] console's clear command does not work.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 02:29 PST by Pavel Feldman
Modified: 2009-12-24 03:06 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed fix (13.26 KB, patch)
2009-12-23 02:32 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-23 02:29:15 PST
It turned out that console's clear command should be in InjectedScriptHost, not InspectorBackend binding.
Comment 1 Pavel Feldman 2009-12-23 02:32:50 PST
Created attachment 45427 [details]
[PATCH] Proposed fix
Comment 2 WebKit Review Bot 2009-12-23 02:33:40 PST
style-queue ran check-webkit-style on attachment 45427 [details] without any errors.
Comment 3 Timothy Hatcher 2009-12-23 12:56:12 PST
Comment on attachment 45427 [details]
[PATCH] Proposed fix

> +    requestClearConsoleMessages: function()
> +    clearConsoleMessages: function()

Having "Console" in these function names is redundant when they are on the ConsoleView object and always referenced in context.
Comment 4 Pavel Feldman 2009-12-24 02:54:13 PST
(In reply to comment #3)
> (From update of attachment 45427 [details])
> > +    requestClearConsoleMessages: function()
> > +    clearConsoleMessages: function()
> 
> Having "Console" in these function names is redundant when they are on the
> ConsoleView object and always referenced in context.

Done.
Comment 5 Pavel Feldman 2009-12-24 03:06:27 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/console-tests.js
	M	WebCore/ChangeLog
	M	WebCore/inspector/InjectedScriptHost.cpp
	M	WebCore/inspector/InjectedScriptHost.h
	M	WebCore/inspector/InjectedScriptHost.idl
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/InjectedScriptAccess.js
	M	WebCore/inspector/front-end/inspector.js
Committed r52545